Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change schema coordinator error logs to warning #920

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix: change schema coordinator error logs to warning #920

merged 1 commit into from
Jul 24, 2024

Conversation

jjaakola-aiven
Copy link
Contributor

The logs changed are warnings, the coordinator should correct the issue.

About this change - What it does

References: #xxxxx

Why this way

@jjaakola-aiven
fix: change schema coordinator error logs to warning
66bf05a 
The logs changed are warnings, the coordinator should correct the issue.
@github-actions GitHub Actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  karapace
  utils.py
  karapace/coordinator
  schema_coordinator.py 280
  karapace/protobuf
  field_element.py
  proto_file_element.py
  proto_normalizations.py
  schema.py
Project Total  

This report was generated by python-coverage-comment-action

@jjaakola-aiven jjaakola-aiven marked this pull request as ready for review July 24, 2024 05:36
@jjaakola-aiven jjaakola-aiven requested review from a team as code owners July 24, 2024 05:36
eliax1996
eliax1996 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@eliax1996 eliax1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change its good, would be nice to have a metric about how long this state its kept and raise an escalation if its more than a threshold

keejon
keejon approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@keejon keejon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@keejon keejon merged commit 83e329a into main Jul 24, 2024
9 checks passed
@keejon keejon deleted the jjaakola-aiven-change-schema-coordinator-error-logs-to-warning branch July 24, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliax1996 eliax1996 eliax1996 approved these changes

@keejon keejon keejon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjaakola-aiven @keejon @eliax1996