Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test flakiness because of timming issues #184

Closed
wants to merge 4 commits into from

Conversation

hackaugusto
Copy link
Contributor

depends on #180

When running the tests with external services it may take a little while for the services to pick up freshly created topics.

Augusto F. Hack added 4 commits March 23, 2021 16:26
This simplifies the fixtures, so it is easier to add a flag to pytest
to use an process started without the fixtures.
Adds CLI options to configure test fixtures for using external services.
Previously this was done with environment variables, the advantage of
the flags is that `pytest --help tests` will show the options, and that
now there is a bit of validation to allow all test to run.
When executing tests with a Kafka broker in a docker container it takes
some additional time for the Rest/Registry servers to synchronize, that
caused flakiness.

The flakiness issues were fixed with a polling tool that waits until the
new topic is seen.
@hackaugusto
Copy link
Contributor Author

moved this commit to #183 because it needs the Expiration class.

@hackaugusto hackaugusto deleted the hacka-tests-fix-timming-with-slow-brokers branch March 25, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant