Fix test master selection and tests with timings issues for topics #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackaugusto
changed the title
hackaugusto
force-pushed
the
hacka-fix-test-master-selection
branch
from
e83c2f2 to
10c7370
Compare
tvainika
changed the title
|
|
added 3 commits
March 24, 2021 10:20
Fixes test_master_selection so that it can ran in parallel. For it to work properly random ports, group_ids, and client_ids are used to prevent conflicts.
When executing tests with a Kafka broker in a docker container it takes some additional time for the Rest/Registry servers to synchronize, that caused flakiness. The flakiness issues were fixed with a polling tool that waits until the new topic is seen.
when executing tests against container services it takes a bit more of time for the services to synchronize. This adds polling for APIs calls that would may fail on the first try because of these timming issues.
hackaugusto
force-pushed
the
hacka-fix-test-master-selection
branch
from
10c7370 to
e1bbfc1
Compare
tvainika
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #180The test for master selection couldn't be run in parallel because the port numbers, group ids, and clients ids conflicted. This changes the test to use random values fixing the flakiness.
I tested this with: