Enable use of unqualified table names in source connector #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0urante
changed the title
C0urante
changed the title
C0urante
force-pushed
the
unqualified-table-names
branch
from
823e62d to
6dc7f4a
Compare
C0urante
force-pushed
the
unqualified-table-names
branch
from
6dc7f4a to
3b682b2
Compare
C0urante
force-pushed
the
unqualified-table-names
branch
from
3b682b2 to
c640f4a
Compare
jeqo
previously approved these changes
Mar 23, 2023
src/main/java/io/aiven/connect/jdbc/source/JdbcSourceConnectorConfig.java
Outdated
Show resolved
Hide resolved
| config.getString(JdbcSourceConnectorConfig.INCREMENTING_COLUMN_NAME_CONFIG); | ||
| if (!qualifyTableNames && (incrementingColumn == null || incrementingColumn.isEmpty())) { | ||
| // Otherwise, we may infer the wrong incrementing key for the table | ||
| // TODO: This restraint is not necessary in all cases, but additional logic will be required to |
There was a problem hiding this comment.
Should this be tracked as an issue?
There was a problem hiding this comment.
I'm on the fence. IMO filing an issue implies that there is immediate action that can/should be taken; this is more of a note about a potential improvement we can investigate in the future if necessary.
...tionTest/java/io/aiven/kafka/connect/jdbc/postgres/UnqualifiedTableNamesIntegrationTest.java
Show resolved
Hide resolved
|
@jeqo thanks for the review! I've updated the config name. Still not sure about ticket vs. TODO; if you have strong feelings one way or the other, can do whatever makes you happy. |
This was referenced Mar 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #219
Depends on #222
A new
table.names.qualifyproperty is introduced, with a default oftrue(which preserves existing behavior). When set tofalse:Existing unit tests are adapted/expanded to cover fine-grained logic for this feature, and a new
UnqualifiedTableNamesIntegrationTestintegration test suite is added to test a few scenarios including different query modes and preservation of offsets across restarts.