Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable unqualified table reads #219

Closed
C0urante opened this issue Mar 6, 2023 · 1 comment
Closed

Enable unqualified table reads #219

C0urante opened this issue Mar 6, 2023 · 1 comment

Comments

@C0urante
Copy link
Contributor

C0urante commented Mar 6, 2023

The source connector uses fully-qualified table names when issuing SELECT queries, and requires that the set of tables that it reads from does not contain any two tables with the same unqualified name.

This makes sense for most use cases, but is unnecessarily restrictive when, e.g., Postgres search paths are used in the source database.

These can be especially useful if there is a single unqualified table name (or set of table names) that should be read from the source database, but the schema they reside in are constantly changing. A search path can be used to automatically direct queries (that use unqualified table names) to the correct schema without requiring any changes to the connector configuration.

In order to support this type of use case, we can allow the connector to be configured to use unqualified table names when reading from the source database. This would also require us to skip the check we currently perform for duplicate unqualified table names (since that's exactly what we'd be facilitating with this feature).

@jeqo
Copy link
Contributor

jeqo commented Mar 27, 2023

Fixed by #223

@jeqo jeqo closed this as completed Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants