Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl+Click opens a raw window #57

Closed
KyGost opened this issue Oct 9, 2020 · 3 comments
Closed

Ctrl+Click opens a raw window #57

KyGost opened this issue Oct 9, 2020 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@KyGost
Copy link
Member

KyGost commented Oct 9, 2020

Control clicking a link opens a raw window (a window without URL bar)
Interestingly, it also triggers the alt menu.
@KyGost
Copy link
Member Author

KyGost commented Oct 9, 2020

Also prevents right click functionality from working

@RangerMauve RangerMauve added the bug Something isn't working label Oct 9, 2020
@RangerMauve
Copy link
Member

This is probably an easy fix.

We need to check what "disposition" is being used when creating the window and add it to the if statement here: https://github.com/AgregoreWeb/agregore-browser/blob/master/app/main.js#L47

@RangerMauve RangerMauve added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 21, 2020
RangerMauve added a commit that referenced this issue Oct 24, 2020
@RangerMauve
Fix #68 and #57
b380af3
@RangerMauve
Copy link
Member

I think this is fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RangerMauve @KyGost