Skip to content
This repository has been archived by the owner on Jun 15, 2024. It is now read-only.

fix: updates to get dapp working with community-dev #62

Merged
merged 5 commits into from
Apr 6, 2023
Merged

Conversation

samsiegart
Copy link
Contributor

@samsiegart samsiegart commented Apr 4, 2023

Summary

Get dapp working with community-dev

Details

The dapp hasn't been updated to align with platform changes in some months. Highlights of the fixes include:

  • Better use of agoric-sdk community-dev branch for a more stable foundation
  • Update a few zoe calls based on API changes
  • Update Far to come from '@endo/far`
  • Update CI to use node 16
  • Update README with new instructions
  • Update the bridge URL from local.aggoric.com to wallet.agoric.app/locator

Testing

Manually ran dapp in a clean checkout w/ a clean checkout of agoric-sdk following the new instructions in README and was able to bid on a card, have the bid accepted.

@samsiegart samsiegart changed the base branch from community-dev-2 to main April 4, 2023 18:23
@samsiegart samsiegart force-pushed the use-cd branch 3 times, most recently from e134024 to 2da7aef Compare April 4, 2023 23:20
@samsiegart samsiegart changed the title wip wip - get dapp working with community-dev Apr 4, 2023
@ivanlei
Copy link
Contributor

ivanlei commented Apr 5, 2023

from @michaelfig

you should be able to use agoric install community-dev to get further (I got past the marshal errors). Now I get test failures in test/test-contract.js pertaining to no more zoe.makeFeePurse nor zoe.bindDefaultFeePurse. That’s just an API change, and the solution to it is to remove all references to the feePurse and just use zoe directly instead of trying to bind it.

@ivanlei ivanlei requested a review from turadg April 6, 2023 16:22
@ivanlei ivanlei changed the title wip - get dapp working with community-dev Updates to get dapp working with community-dev Apr 6, 2023
@ivanlei ivanlei changed the title Updates to get dapp working with community-dev fix: updates to get dapp working with community-dev Apr 6, 2023
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes overall look good. Before merge the commits should be cleaned up to use conventional commits style and to squash the fixups into the commit nominally changing. E.g. "WIP: yarn once again works locally" should be part of the lint fix.

Incidentally, all commits are implicitly "WIP" until they reach master so I suggest leaving that off in the future.

ui/src/conf/defaults.js Show resolved Hide resolved
.github/workflows/lint-test.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
samsiegart and others added 5 commits April 6, 2023 15:22
This change gets tests passing when using `agoric install community-dev`.

Changes to `yarn.lock` were rolled back with `git checkout a02e584 yarn.lock` and then a few Zoe API calls needed updating in tests.

While tests pass and the dapp connects to the wallet, the card store circles forever waiting to load the cards.
@ivanlei ivanlei merged commit f913108 into main Apr 6, 2023
@ivanlei ivanlei deleted the use-cd branch April 6, 2023 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants