Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support version suffix to publish dev dist-tags #7336

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Conversation

michaelfig
Copy link
Member

refs: Agoric/dapp-card-store#62

Description

Provide a way to attach dist-tags to posthumous NPM packages published as $package@$version-$tag.

Security Considerations

No additional security considerations beyond the authority already granted to NPM accounts to manipulate dist-tags.

Scaling Considerations

n/a

Documentation Considerations

Some description of using yarn install community-dev should be written to point new developers in the right direction when using the published packages as the basis for a dapp. Also, maintainers should be educated in updating the dist-tags when advancing the community-dev Git branch.

Testing Considerations

Manually tested in card store dapp.

@michaelfig michaelfig self-assigned this Apr 5, 2023
@michaelfig michaelfig added bypass:integration Prevent integration tests from running on PR tooling repo-wide infrastructure labels Apr 5, 2023
@michaelfig michaelfig requested review from turadg and JimLarson April 5, 2023 16:42
@michaelfig michaelfig added the automerge:no-update (expert!) Automatically merge without updates label Apr 5, 2023
@mergify mergify bot merged commit 9f2254e into master Apr 5, 2023
@mergify mergify bot deleted the mfig-dist-tag branch April 5, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:no-update (expert!) Automatically merge without updates bypass:integration Prevent integration tests from running on PR tooling repo-wide infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants