Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update after-merge workflow to tolerate non-dirty git state #9721

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

gibson042
Copy link
Member

@gibson042 gibson042 commented Jul 16, 2024

Ref #9709
Ref #9708

Description

As of #9709, git state might not include untracked files after our custom restore-node GitHub action, in which case the after-merge workflow job "dev-canary" will execute a no-op git stash followed later by a no-op git stash apply, the latter of which exits with a non-zero status code that fails the step and thereby the containing job.

This PR fixes things to tolerate absence of any stashed changes.

Security Considerations

No relevant change.

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

It's difficult to test these kinds of changes, but the proof of the pudding is in the taste.

Upgrade Considerations

n/a

@gibson042 gibson042 requested review from mhofman and michaelfig July 16, 2024 20:01
@gibson042 gibson042 force-pushed the gibson-9708-followup branch from 284090f to 51daaa5 Compare July 16, 2024 20:05
Copy link

cloudflare-workers-and-pages bot commented Jul 16, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 51daaa5
Status: ✅  Deploy successful!
Preview URL: https://f70ee61f.agoric-sdk.pages.dev
Branch Preview URL: https://gibson-9708-followup.agoric-sdk.pages.dev

View logs

@gibson042 gibson042 force-pushed the gibson-9708-followup branch from 51daaa5 to 72a3271 Compare July 16, 2024 20:06
@gibson042 gibson042 added the automerge:squash Automatically squash merge label Jul 16, 2024
@mergify mergify bot merged commit 294c67b into master Jul 16, 2024
87 of 88 checks passed
@mergify mergify bot deleted the gibson-9708-followup branch July 16, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:squash Automatically squash merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants