ci: Update restore-node dirty check to ignore untracked endo-sha.txt #9709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
8a094a7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://61a2d4a9.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-9708-restore-node-cac.agoric-sdk.pages.dev |
michaelfig
reviewed
Jul 15, 2024
michaelfig
approved these changes
Jul 16, 2024
|
@gibson042 any plan to land this PR today/this week? Looks like there are a few victims to this CI bug. |
* Separate steps with blank lines. * Define conditional-step "if" before properties relevant to its execution. * Define step "working-directory"/"env"/"shell" before shell code to "run". * Prefix github-script console.log output with a label.
gibson042
force-pushed
the
gibson-9708-restore-node-cache-assertions
branch
from
e3e198c to
0b15167
Compare
gibson042
added a commit
that referenced
this pull request
Jul 16, 2024
gibson042
added a commit
that referenced
this pull request
Jul 16, 2024
gibson042
added a commit
that referenced
this pull request
Jul 16, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
Ref #9709 Ref #9708 ## Description As of #9709, git state may not include untracked files after our custom [restore-node GitHub action](https://github.com/Agoric/agoric-sdk/blob/7bde505dd23289218a19bc86f8e94bbff48b65e0/.github/actions/restore-node/action.yml), in which case the after-merge workflow job "dev-canary" will execute a [no-op `git stash` followed later by a no-op `git stash apply`](https://github.com/Agoric/agoric-sdk/blob/7bde505dd23289218a19bc86f8e94bbff48b65e0/.github/workflows/after-merge.yml#L78-L84), the latter of which exits with a non-zero status code that fails the step and thereby the containing job. This PR fixes things to tolerate absence of any stashed changes. ### Security Considerations No relevant change. ### Scaling Considerations n/a ### Documentation Considerations n/a ### Testing Considerations It's difficult to test these kinds of changes, but the proof of the pudding is in the taste. ### Upgrade Considerations n/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9708
Description
Tolerates removal of endo-sha.txt by e.g.
git reset --hard HEADcontributing to a restored cache state. Also includes minor cleanup of GitHub actions files.Security Considerations
No relevant change.
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
It's difficult to test these kinds of changes, but the proof of the pudding is in the taste.
Upgrade Considerations
n/a