refactor(kmarshal): simplify makeStandinPromise #9475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
48782ba
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c8a7b7b4.agoric-sdk.pages.dev |
| Branch Preview URL: | https://markm-9434-simplify-makestan.agoric-sdk.pages.dev |
turadg
reviewed
Jun 9, 2024
|
Since both master and the released code depends on newer endo version, I believe it's safe to merge this. |
turadg
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9434
refs: #XXXX
Description
This removes a kludge needed to accommodate an ancient version of endo. The kludge should no longer be needed, and the remaining code can be simpler.
However, we cannot actually merge this PR to master until we know we do not need to worry about this ancient version of endo.
Altogether, the kludge is small and cheap, so there's nothing urgent about merging this PR. We should wait until we're confident about the compat risk.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
none
Upgrade Considerations
none