You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// TODO This Bizarro world hack is only for the version of Endo that
// agoric-sdk currently depends on, and is already inconsistent with
// the "current" endo. Once agoric-sdk depends only on the next endo,
// we should delete this code, and rename `makeStringStandinPromise`
// above to `makeStandinPromise`.
That's working around an Endo version compatibility. Once we don't need that anymore we should remove it to reduce complexity (and questions about when to remove the hack).
Description of the Design
First verify that with current agoric-sdk line 89 at
closes: #9434
refs: #XXXX
## Description
This removes a kludge needed to accommodate an ancient version of endo. The kludge should no longer be needed, and the remaining code can be simpler.
However, we cannot actually merge this PR to master until we know we do not need to worry about this ancient version of endo.
- [ ] identify what version of endo fixed the problem that the kludge addressed
- [ ] figure out whether that should still inhibit merging this simplification.
Altogether, the kludge is small and cheap, so there's nothing urgent about merging this PR. We should wait until we're confident about the compat risk.
### Security Considerations
none
### Scaling Considerations
none
### Documentation Considerations
none
### Testing Considerations
none
### Upgrade Considerations
none
What is the Problem Being Solved?
kmarshall has a hack:
agoric-sdk/packages/kmarshal/src/kmarshal.js
Lines 41 to 45 in bfb7cdc
That's working around an Endo version compatibility. Once we don't need that anymore we should remove it to reduce complexity (and questions about when to remove the hack).
Description of the Design
First verify that with current agoric-sdk line 89 at
agoric-sdk/packages/kmarshal/src/kmarshal.js
Line 89 in bfb7cdc
Add tests that would fail if it weren't
Remove the hack
Security Considerations
Scaling Considerations
Test Plan
Upgrade Considerations
The text was updated successfully, but these errors were encountered: