Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove makeStringStandinPromise #9434

Closed
turadg opened this issue May 31, 2024 · 0 comments · Fixed by #9475
Closed

remove makeStringStandinPromise #9434

turadg opened this issue May 31, 2024 · 0 comments · Fixed by #9475

Comments

@turadg
Copy link
Member

turadg commented May 31, 2024

What is the Problem Being Solved?

kmarshall has a hack:

// TODO This Bizarro world hack is only for the version of Endo that
// agoric-sdk currently depends on, and is already inconsistent with
// the "current" endo. Once agoric-sdk depends only on the next endo,
// we should delete this code, and rename `makeStringStandinPromise`
// above to `makeStandinPromise`.

That's working around an Endo version compatibility. Once we don't need that anymore we should remove it to reduce complexity (and questions about when to remove the hack).

Description of the Design

First verify that with current agoric-sdk line 89 at

return [makeStringStandinPromise, getStringStandinPromiseTag];
is executed

Add tests that would fail if it weren't

Remove the hack

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@mergify mergify bot closed this as completed in #9475 Jul 3, 2024
mergify bot pushed a commit that referenced this issue Jul 3, 2024
closes: #9434 
refs: #XXXX

## Description

This removes a kludge needed to accommodate an ancient version of endo. The kludge should no longer be needed, and the remaining code can be simpler.

However, we cannot actually merge this PR to master until we know we do not need to worry about this ancient version of endo.

- [ ] identify what version of endo fixed the problem that the kludge addressed
- [ ] figure out whether that should still inhibit merging this simplification.

Altogether, the kludge is small and cheap, so there's nothing urgent about merging this PR. We should wait until we're confident about the compat risk.

### Security Considerations

none
### Scaling Considerations

none
### Documentation Considerations

none
### Testing Considerations

none
### Upgrade Considerations

none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant