Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: eliminate fee double-charge by using configurable decorator #9051
fix: eliminate fee double-charge by using configurable decorator #9051
Changes from all commits
1ff7ea7
1b12c7e
1f75fd8
2551258
9ac6222
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the new tag be v0.46.16-alpha.agoric.3? I feel like I'm missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.3
was already taken by future incompatible changes (waiting in the wings of an agoric-sdk PR, but I'm not sure which one)..2.1
implies the first published revision of.2
, which is more accurate.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't use the current tip of
Agoric
since lien support was removed in agoric-labs/cosmos-sdk#385 (in accordance with #8988, which is onmaster
but not cherry-picked into the upgrade-14 release branch). So we need to use a side branch ofAgoric
for the new fee decorator feature. Our naming convention is to use<cosmos-release>-alpha.agoric.N
sequentially onAgoric
,...-alpha.agoric.N.M
for sub-branches, and presumably...N.M.P
for sub-sub-branches, etc. I'll document the policy in that repo.