refactor: remove lien mechanism support #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lien feature was implemented by having every account pretend it was a vesting account, where the liened amount would appear unvested. A wrapper was placed around AccountKeeper so every account retrieved from the store would be itself wrapped in a ficticious vesting account implementing this mechanism. But operations against a real vesting account, e.g. clawback, adding a new grant, etc, would have to be routed to the wrapped underlying account. Complicating this, the wrapper code lived in the agoric-sdk repository, and we had to avoid importing that, and circular imports all around. The gist of this commit is that without these account wrappers, simple type casts work and the interface and "action" gymnastics are no longer needed. Actions on a vesting account can simply be ordinary methods.
A context was needed for the lien feature to look up records in the store. This usage has been removed.
JimLarson
added
enhancement
|
The failing lint check is expected. |
michaelfig
approved these changes
Mar 3, 2024
|
|
||
| // NewAccountKeeper returns a new AccountKeeper that uses go-amino to | ||
| // NewAccountKeeper returns a new AccountKeeperI that uses go-amino to |
There was a problem hiding this comment.
Suggested change
| // NewAccountKeeper returns a new AccountKeeperI that uses go-amino to | |
| // NewAccountKeeper returns a new AccountKeeper that uses go-amino to |
There was a problem hiding this comment.
This error is in the cosmos release, so I'm going to err on the side of minimizing our fork footprint. We can fix it in upstream some day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: Agoric/agoric-sdk#8989
AccountKeeperinto an interface.*Actioninterfaces for vesting accounts and simplify the implementations of AddGrant, ReturnGrant, Clawback, etc.Reduces the footprint of our fork.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...