feat: Check that makeInstance() returns an actual invite #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katelynsills
suggested changes
Apr 10, 2020
packages/zoe/src/zoe.js
Outdated
| @@ -543,7 +543,12 @@ const makeZoe = (additionalEndowments = {}) => { | |||
| // Once the contract is made, we add the publicAPI to the | |||
| // contractRecord | |||
| instanceTable.update(instanceHandle, { publicAPI }); | |||
| return invite; | |||
| return inviteIssuer.isLive(invite).then(success => { | |||
| if (success) { | |||
There was a problem hiding this comment.
Can we use an assert here and reverse the return and the error check?
Suggested change
| if (success) { | |
| assert(success, details`invites must be issued by the inviteIssuer.`); | |
| return invite; |
| const issuerKeywordRecord = harden({ Contribution: moolaR.issuer }); | ||
|
|
||
| // 1: Alice tries to create an instance, but the contract is badly written. | ||
| zoe.makeInstance(installationHandle, issuerKeywordRecord).then( |
There was a problem hiding this comment.
I think we should use t.throws here. Is there a reason not to?
There was a problem hiding this comment.
makeInstance is async. I couldn't find a way to await the result. It doesn't throw until the test is done.
There was a problem hiding this comment.
t.rejects() works.
Chris-Hibbert
force-pushed
the
checkInvite
branch
from
8313504 to
79a52c4
Compare
katelynsills
approved these changes
Apr 10, 2020
Chris-Hibbert
force-pushed
the
checkInvite
branch
from
79a52c4 to
8d509c1
Compare
Includes a test. closes #820
Chris-Hibbert
force-pushed
the
checkInvite
branch
2 times, most recently
from
8eab627 to
ab54fb9
Compare
Chris-Hibbert
force-pushed
the
checkInvite
branch
from
ab54fb9 to
5509692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a test.
closes #820