Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zoe] Check that invite field of makeInstance return value is an actual invite #820

Closed
DavidBruant opened this issue Mar 31, 2020 · 1 comment · Fixed by #904
Closed
Assignees
Labels
Zoe package: Zoe
Milestone

Comments

@DavidBruant
Copy link
Contributor

DavidBruant commented Mar 31, 2020

No check is performed on the invite field ; it is returned as it is

.then(_ => installation.makeContract(contractFacet))
.then(({ invite, publicAPI }) => {
// Once the contract is made, we add the publicAPI to the
// contractRecord
instanceTable.update(instanceHandle, { publicAPI });
return invite;
});

Edit below by Kate 4/7:
We should add a check:

inviteIssuer.isLive(invite)
This will take another turn since isLive returns a promise.

@DavidBruant DavidBruant added the Zoe package: Zoe label Mar 31, 2020
@katelynsills
Copy link
Contributor

Not doing a check isn't intentional, so this is a great issue. I think we could do:

inviteIssuer.isLive(invite)

This will take another turn since isLive returns a promise, but I think we should do it.

@katelynsills katelynsills self-assigned this Mar 31, 2020
@katelynsills katelynsills changed the title Anything can be returned for the invite field of makeInstance [Zoe] Check that invite field of makeInstance return value is an actual invite Apr 7, 2020
@katelynsills katelynsills added this to the Zoe 0.5.0 milestone Apr 7, 2020
Chris-Hibbert added a commit that referenced this issue Apr 9, 2020
Chris-Hibbert added a commit that referenced this issue Apr 10, 2020
Chris-Hibbert added a commit that referenced this issue Apr 10, 2020
Chris-Hibbert added a commit that referenced this issue Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Zoe package: Zoe
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants