Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rebalance CI #7393

Merged
merged 3 commits into from
Apr 12, 2023
Merged

rebalance CI #7393

merged 3 commits into from
Apr 12, 2023

Conversation

turadg
Copy link
Member

@turadg turadg commented Apr 12, 2023

Description

The CI refactoring in #7391 resulted in test-quick2 being much faster than the rest:
Screenshot 2023-04-12 at 8 39 01 AM

test-quick is slower than average so this rebalances them.

I also noticed we're running test:xs unnecessarily on some packages so this drops those.

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

@turadg turadg requested review from michaelfig and dckc April 12, 2023 15:53
michaelfig
michaelfig approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please mark with bypass:integration and document which checks should be marked as required and not required before landing this.

Then, you'll need to coordinate with a repo admin about changing the master branch protection rules accordingly.

@turadg turadg added automerge:no-update (expert!) Automatically merge without updates bypass:integration Prevent integration tests from running on PR labels Apr 12, 2023
@turadg turadg mentioned this pull request Apr 12, 2023
Merged
@turadg turadg merged commit d372ecd into master Apr 12, 2023
@turadg turadg deleted the ta/rebalance-ci branch April 12, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfig michaelfig michaelfig approved these changes

@dckc dckc Awaiting requested review from dckc

Assignees
No one assigned
Labels
automerge:no-update (expert!) Automatically merge without updates bypass:integration Prevent integration tests from running on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turadg @michaelfig