Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor cleanups in preparation for Endo upgrade #7391

Merged
merged 4 commits into from
Apr 14, 2023
Merged

fix: minor cleanups in preparation for Endo upgrade #7391

merged 4 commits into from
Apr 14, 2023

Conversation

michaelfig
Copy link
Member

@michaelfig michaelfig commented Apr 12, 2023 •
edited
Loading

refs: #7090

Description

Picking some minor nits found while scouring the code during the Endo integration work.

  • Relax a Zoe exit rejection message test, as it varies depending on whether Zoe noticed the exit before asking ZCF
  • Automatically rebuild some missing bundles in inter-protocol tests found by rm -rf bundles && yarn test
  • Clear up messages sent by the solo's captp implementation
  • Prepare for some exports of @endo/eventual-send that will be made internal in an upcoming release

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

@michaelfig michaelfig requested review from turadg and dckc April 12, 2023 03:34
@michaelfig michaelfig self-assigned this Apr 12, 2023
turadg
turadg reviewed Apr 12, 2023
View reviewed changes
packages/inter-protocol/package.json Outdated Show resolved Hide resolved
scripts/replace-packages.sh Outdated Show resolved Hide resolved
@turadg turadg mentioned this pull request Apr 12, 2023
Merged
@michaelfig michaelfig force-pushed the mfig-ci-updates branch 3 times, most recently from 99ba8fc to e6f346a Compare April 13, 2023 17:55
@michaelfig michaelfig marked this pull request as draft April 13, 2023 17:59
Base automatically changed from mfig-ci-updates to master April 13, 2023 21:13
@michaelfig michaelfig requested a review from turadg April 13, 2023 23:23
@michaelfig michaelfig marked this pull request as ready for review April 14, 2023 01:44
@michaelfig michaelfig requested a review from turadg April 14, 2023 01:44
turadg
turadg approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michaelfig michaelfig added the automerge:no-update (expert!) Automatically merge without updates label Apr 14, 2023
@mergify mergify bot merged commit aed398a into master Apr 14, 2023
@mergify mergify bot deleted the mfig-looser-tests branch April 14, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turadg turadg turadg approved these changes

@dckc dckc Awaiting requested review from dckc

Assignees

@michaelfig michaelfig

Labels
automerge:no-update (expert!) Automatically merge without updates test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelfig @turadg