Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simplify unnecessary promise #6479

Merged
merged 1 commit into from
Oct 20, 2022
Merged

fix: simplify unnecessary promise #6479

merged 1 commit into from
Oct 20, 2022

Conversation

erights
Copy link
Member

@erights erights commented Oct 20, 2022

We already happen to have the resolved reference due to an earlier await so may as well use that.

Noticed while working on #6475

@erights erights requested a review from turadg as a code owner October 20, 2022 06:15
@erights erights self-assigned this Oct 20, 2022
@erights erights requested a review from Chris-Hibbert October 20, 2022 06:15
turadg
turadg approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

For commit history: not a fix since it doesn't change behavior. Should be refactor: or chore:. Not worth another push and CI round but perhaps for the future.

@erights erights added the automerge:squash Automatically squash merge label Oct 20, 2022
@mergify mergify bot merged commit ffe5e7f into master Oct 20, 2022
@mergify mergify bot deleted the markm-unnecessary-promise branch October 20, 2022 15:55
dtribble pushed a commit that referenced this pull request Oct 24, 2022
@erights @dtribble
fix: simplify unnecessary promise (#6479)
17f6b0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turadg turadg turadg approved these changes

@Chris-Hibbert Chris-Hibbert Awaiting requested review from Chris-Hibbert

Assignees

@erights erights

Labels
automerge:squash Automatically squash merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erights @turadg