fix: Tighten invitation proposal patterns #6475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
approved these changes
Oct 19, 2022
erights
force-pushed
the
markm-multiples
branch
from
48b0552 to
271f25d
Compare
erights
force-pushed
the
markm-invitation-proposal-patterns
branch
from
7fe7b4c to
2572b44
Compare
erights
force-pushed
the
markm-multiples
branch
from
271f25d to
052608e
Compare
erights
force-pushed
the
markm-invitation-proposal-patterns
branch
from
2572b44 to
61e619c
Compare
|
Reviewers, especially for the occurrences of |
erights
force-pushed
the
markm-multiples
branch
from
052608e to
6108ad2
Compare
erights
force-pushed
the
markm-invitation-proposal-patterns
branch
from
b7fd28c to
30f1a1f
Compare
erights
force-pushed
the
markm-multiples
branch
from
6108ad2 to
3b7f81d
Compare
erights
force-pushed
the
markm-invitation-proposal-patterns
branch
from
30f1a1f to
9165c33
Compare
erights
force-pushed
the
markm-multiples
branch
from
3b7f81d to
822e0e0
Compare
erights
force-pushed
the
markm-invitation-proposal-patterns
branch
from
9165c33 to
5910533
Compare
erights
force-pushed
the
markm-multiples
branch
from
822e0e0 to
14f61e6
Compare
erights
force-pushed
the
markm-invitation-proposal-patterns
branch
from
5910533 to
5dee4d6
Compare
erights
force-pushed
the
markm-multiples
branch
from
14f61e6 to
51dbd75
Compare
erights
force-pushed
the
markm-invitation-proposal-patterns
branch
from
5dee4d6 to
c2e8a4f
Compare
erights
force-pushed
the
markm-multiples
branch
from
51dbd75 to
59b5061
Compare
erights
force-pushed
the
markm-invitation-proposal-patterns
branch
from
c2e8a4f to
55b5868
Compare
erights
force-pushed
the
markm-multiples
branch
from
59b5061 to
babdfcb
Compare
erights
force-pushed
the
markm-invitation-proposal-patterns
branch
from
55b5868 to
2527e69
Compare
erights
commented
Dec 14, 2022
Comment on lines
292
to
277
| M.splitRecord({ | ||
| give: { In: stableAmountShape }, | ||
| want: M.or({ Out: anchorAmountShape }, {}), | ||
| multiples: 1n, | ||
| exit: M.any(), | ||
| }), |
There was a problem hiding this comment.
This now represents all the fields of the record, not just a subset. Thus, the M.splitRecord should be removed and the record pattern should be the proposalShape directly.
erights
force-pushed
the
markm-multiples
branch
from
babdfcb to
dda01a1
Compare
erights
force-pushed
the
markm-invitation-proposal-patterns
branch
from
489d586 to
3fd944b
Compare
erights
force-pushed
the
markm-multiples
branch
from
dda01a1 to
58585f3
Compare
erights
force-pushed
the
markm-invitation-proposal-patterns
branch
2 times, most recently
from
872f99b to
d6104d8
Compare
erights
force-pushed
the
markm-multiples
branch
from
ab4733f to
6011664
Compare
erights
force-pushed
the
markm-invitation-proposal-patterns
branch
from
d6104d8 to
6b620ad
Compare
erights
force-pushed
the
markm-multiples
branch
from
6011664 to
3c86bbe
Compare
erights
force-pushed
the
markm-invitation-proposal-patterns
branch
from
6b620ad to
1a4f7f3
Compare
erights
force-pushed
the
markm-multiples
branch
from
3c86bbe to
0b50061
Compare
erights
force-pushed
the
markm-invitation-proposal-patterns
branch
from
1a4f7f3 to
8f7d674
Compare
erights
force-pushed
the
markm-multiples
branch
from
abcd42a to
c7cfdde
Compare
|
Closing in favor of #7041 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staged on #5422 "multiples"
Use tight proposal patterns on production invitations to, among other things, see if the Zoe prohibition on wash invitations is something we should bother preserving. (My assumption is not, but worth doing some of this experiment first.)