upgrade to Ava 4.3 #5793
Merged
upgrade to Ava 4.3 #5793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
force-pushed
the
4895-ava-4.3
branch
3 times, most recently
from
945f93e
to
63a5077
Compare
turadg
force-pushed
the
4895-ava-4.3
branch
2 times, most recently
from
ffcb4c9
to
05168be
Compare
warner
approved these changes
Aug 4, 2022
| @@ -77,7 +77,8 @@ | |||
| "files": [ | |||
| "test/**/test-*.js" | |||
| ], | |||
| "timeout": "20m" | |||
| "timeout": "20m", | |||
| "workerThreads": false | |||
There was a problem hiding this comment.
After this lands, I'd be curious to remove this and see if it affects anything. If "workerThreads" share a JS heap, then we'll probably need to keep it disabled. But maybe they only share a unix process memoryspace, and still have separate instances of the V8 engine (and thus separate JS heaps, so their GC doesn't affect each other), in which case we could use them.
There was a problem hiding this comment.
Yeah I would like to remove this config wherever possible. In my testing these packages failed without this, but maybe we can solve those cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #4895
supplants: #5201
Description
Upgrade Ava to v4 for the reasons in #4895 and to perhaps help debug #5575 .
Security Considerations
--
Documentation Considerations
Ava version will now match the docs on the Ava repo.
Testing Considerations
A few repo integration tests are breaking due to conflicting versions. Only non-required ones are left and I'll burn those down soon.