fix: reinstate economy boot using minInitialPoolLiquidity=0 #5441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
May 26, 2022
Comment on lines
+45
to
+46
| async mint => { | ||
| await zcf.saveIssuer(secondaryIssuer, keyword); |
| @@ -415,7 +425,7 @@ test('Benefactor can add to reserve', async t => { | |||
| await s.startDevNet(); | |||
| await s.provisionMembers(); | |||
| await s.startRunPreview(); | |||
| await s.benefactor.makePool(2000n, 1000n); | |||
| // await s.benefactor.makePool(2000n, 1000n); | |||
There was a problem hiding this comment.
justification above doesn't suffice?
// This isn't used now that we make the pool from a denom
// in publishInterchainAssetFromBank in addAssetToVault.js
// But it should still work. TODO: Perhaps we should test both ways?
// i.e. from a board ID as well?
basically: this design has flip-flopped rapidly recently. I'd like to keep it there as a hedge.
17 tasks
- restore support for $INTERCHAIN_DENOM - allow passing env explicitly with process.env as a default - fix: minInitialPoolLiquidity goes inside options - addPool in publishInterchainAssetFromBank in proposals/addAssetToVault.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #5375
obsoletes: #5428
Description
make scenario2-run-chain-to-haltin cosmic-swingset)minInitialPoolLiquidityto 0 in "economy" bootstrappublishInterchainAssetFromBank), add it to the AMM, assumingminInitialPoolLiquidityis 0await zcf.saveIssuer()(drive-by, found during testing)Security Considerations
Users of "economy" bootstrap must manage the risk of spam AMM pools.
Documentation Considerations
can't think of any
Testing Considerations
restoring
test-gov-collateral.jsto working order was a bit challenging; thebenefactor.makePool()code is now dead code, but I left a TODO to test that path, so I'm inclined to keep it around.