Add addPool to AMM creatorFacet and reinstate economy boot

[michaelfig]

refs: #5375

Description

• Put addPool on the AMM creatorFacet, primarily to un-tie knots in automated bootstrap; not intended for normal production use.
• Fix economy bootstrap, and add to CI.

Security Considerations

Documentation Considerations

Testing Considerations

[turadg]

I think this should be done before merge to DRY out the two addPools. They've already diverged in that the other one updates metrics. cc @Chris-Hibbert

[turadg]

noting #5407 to link this instance to that ticket

[Chris-Hibbert]

This makes it possible to create a new empty pool, violating the requirement for a minimum funding. It also allows/requires the pool to be funded using addLiquidity rather than going through addPoolAndLiquidityHandler, which means that no liquidity will be extracted to the reserve.

[dckc]

@Chris-Hibbert , this no-fee addPool method is primarily intended to un-tie knots in automated bootstrap; it's not intended for normal production use. (I clarified the PR description to say as much.)

This makes it possible to create a new empty pool, violating the requirement for a minimum funding.

The motivation for minimum funding was essentially spam prevention, wasn't it? This no-fee addPool method is on the creator facet, which is only available to the BLDer DAO, not to spammers. There's nothing inherently wrong with an empty AMM pool, is there?

It also allows/requires the pool to be funded using addLiquidity rather than going through addPoolAndLiquidityHandler, which means that no liquidity will be extracted to the reserve.

Yes, this is a consideration that anyone with access to the AMM creator facet should be aware of. Is it a reason not to add the feature, though?

[dckc]

discussion with @Chris-Hibbert , @dtribble and co suggests:

• try PSM?
• try 0 minimum required liquidity?

[dckc]

obsolete in favor of #5441