Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update eslint to prevent dapp-card-store build issues #2806

Closed
wants to merge 2 commits into from
Closed

chore: update eslint to prevent dapp-card-store build issues #2806

wants to merge 2 commits into from

Conversation

katelynsills
Copy link
Contributor

@katelynsills katelynsills commented Apr 5, 2021 •
edited
Loading

closes #2797

@erights
Copy link
Member

erights commented Apr 5, 2021

@katelynsills have you seen #2805 ? Can you review those as a group instead?

michaelfig
michaelfig previously approved these changes Apr 5, 2021
View reviewed changes
@michaelfig michaelfig dismissed their stale review April 5, 2021 16:48

Prefer @erights change.

@erights
Copy link
Member

erights commented Apr 5, 2021

The latest I see among our repos is 7.23.0, so why 7.11.0 ? #2805 does 7.23.0

@katelynsills
Copy link
Contributor Author

@katelynsills have you seen #2805 ? Can you review those as a group instead?

I did see it, but I don't think it's on the critical path for Beta, so I'm putting it on the back burner for now. This PR is necessary though.

@erights
Copy link
Member

erights commented Apr 5, 2021

Why not #2804?

@katelynsills
Copy link
Contributor Author

The latest I see among our repos is 7.23.0, so why 7.11.0 ? #2805 does 7.23.0

I'm limited on time and just trying to fix the error, and create-react-app uses 7.11.0 right now. Updating all our dependencies or all of eslint is bigger than I can do right now.

erights
erights requested changes Apr 5, 2021
View reviewed changes
Copy link
Member

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not #2804 ?

@erights
Copy link
Member

erights commented Apr 5, 2021

Sorry, I see the answer. But #2804 is green. Doesn't that mean it is non-problematic?

@erights
Copy link
Member

erights commented Apr 5, 2021

(Green modulo XS, but that's independent)

@katelynsills
Copy link
Contributor Author

Sorry, I see the answer. But #2804 is green. Doesn't that mean it is non-problematic?

Sure, that's fine. I just approved it and will close this.

@katelynsills katelynsills deleted the update-eslint branch April 5, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erights erights erights requested changes

@dtribble dtribble dtribble approved these changes

@michaelfig michaelfig michaelfig left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade ESLint to fix dapp-card-store build error
4 participants
@katelynsills @erights @michaelfig @dtribble