Menu #131
Merged
Menu #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onent with hopes to simplify the interface a bit.
…still need to refactor MenuTrigger to use ForwardRef So we can set focus back on it via the ref.
…er button if menu is closed via ESC. closeOnSelect boolean prop. onOpen and onClose hooks. Cleans up the code a bit.
…item ones. Updates React for refactor. Gets further on Svelte menu too.
…es some console.logs too.
|
I don't like long-running PR's / branches and so I'm going to merge this as is. It's pretty much good but I cannot build or deploy the site docs for now vuejs/vitepress#537 (comment) -- I think I'm going to await Vitepress fix on this and then will resume later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Menus
This is for #88
I'm going to KISS and so far this is where I'm headed (html/css static example):
type: moduleto get it to work with Astro as Vite was complaining it couldn't detect agnostic-vue as an ESM so to use the type:module (or .mjs):vuejs/vitepress#537 (comment)