Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menus (menuitem) (4/14) #88

Closed
9 tasks done
roblevintennis opened this issue Dec 18, 2021 · 1 comment
Closed
9 tasks done

Menus (menuitem) (4/14) #88

roblevintennis opened this issue Dec 18, 2021 · 1 comment
Assignees
Labels
Done Something that is complete enhancement New feature or request
Milestone

Comments

@roblevintennis
Copy link
Contributor

roblevintennis commented Dec 18, 2021

Overview

This task is to implement single select menus that support he role="menuitem" only. Other options can be tackled in MenuOptionGroups at a later date.

  • CSS
  • React
  • React Examples
  • Svelte
  • Svelte Examples
  • Vue 3
  • Vue Examples
  • Publish frameworks

BLOCKED

I've got this updated and can run the menu docs page locally but cannot build. Here's more context…

  • Site Docs -- I've got this mostly working but I'm temporarily stalled by Vitepress issue (I updated agnostic-vue's package.json to type: module to get it to work with Astro as Vite was complaining it couldn't detect agnostic-vue as an ESM so to use the type:module (or .mjs):

vuejs/vitepress#537 (comment)

@roblevintennis roblevintennis changed the title Menus Menus (4/21) Dec 18, 2021
@roblevintennis roblevintennis changed the title Menus (4/21) Menus (4/7) Dec 18, 2021
@roblevintennis roblevintennis self-assigned this Dec 18, 2021
@roblevintennis roblevintennis added the enhancement New feature or request label Dec 18, 2021
@roblevintennis roblevintennis added this to the MVP milestone Dec 18, 2021
@roblevintennis roblevintennis changed the title Menus (4/7) Menus (3/21) Jan 4, 2022
@roblevintennis roblevintennis changed the title Menus (3/21) Menus (2/28) Jan 27, 2022
@roblevintennis roblevintennis changed the title Menus (2/28) Menus (2/21) Jan 27, 2022
@roblevintennis roblevintennis changed the title Menus (2/21) Menus (3/7) Feb 7, 2022
@roblevintennis roblevintennis changed the title Menus (3/7) Menus (3/31) Feb 7, 2022
@roblevintennis roblevintennis changed the title Menus (3/31) Menus (4/14) Mar 13, 2022
@roblevintennis roblevintennis moved this from Todo to In Progress in AgnosticUI MVP Mar 20, 2022
This was referenced Mar 20, 2022
@roblevintennis roblevintennis changed the title Menus (4/14) Menus (menuitem) (4/14) Mar 25, 2022
@roblevintennis roblevintennis added good first issue Good for newcomers help wanted Extra attention is needed and removed good first issue Good for newcomers help wanted Extra attention is needed labels Mar 29, 2022
@roblevintennis
Copy link
Contributor Author

UPDATE:
I had an realization that while I wait for this Vitepress issue to get sorted, I can actually use following workaround (kludgy as it is):

  1. Remove the type: module from agnostic-vue/package.json
  2. Rename files like copystyles.js to copystyles.mjs if get errors
  3. Run npm run build && npm pack
  4. Install in /site e.g. npm i /Users/roblevin/workspace/opensource/agnosticui/agnostic-vue/agnostic-vue-1.0.20.tgz provided building packed npm per previous step
  5. npm run docs:build should now work as will ./deploy.sh
  6. **Do not forget to go back and set type: module

Repository owner moved this from In Progress to Done in AgnosticUI MVP Mar 30, 2022
@roblevintennis roblevintennis added the Done Something that is complete label Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done Something that is complete enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant