Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addressing #395 #396

Merged
merged 3 commits into from
Jun 28, 2024
Merged

addressing #395 #396

merged 3 commits into from
Jun 28, 2024

Conversation

amirfz
Copy link
Contributor

@amirfz amirfz commented Jun 25, 2024

Description

addressing the demo issue documented in #395 . essentially replacing the existing document search demo with an up to date version consistent with tutorials

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

#395

Checklists

To speed up the review process, please follow these checklists:

Development

  • The Pull Request is small and focused on one topic
  • Lint rules pass locally (make format && make lint)
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development (make test)
  • The changes generate no new warnings (or explain any new warnings and why they're ok)
  • Commit messages are detailed
  • Changed code is self-explanatory and/or I added comments
  • I updated the documentation (docstrings, /docs)
    See the testing guidelines for help on tests, especially those involving web services.

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • I have performed a self-review of my code
  • Issue from task tracker has a link to this pull request

💔 Thank you for submitting a pull request!

@20001LastOrder 20001LastOrder self-requested a review June 25, 2024 20:48
@20001LastOrder
Copy link
Collaborator

It seems to contain quite some unnecessary files. I will need to clean it up a bit

@amirfz
Copy link
Contributor Author

amirfz commented Jun 26, 2024 via email

@amirfz
Copy link
Contributor Author

amirfz commented Jun 26, 2024

@20001LastOrder removed the extra files from this PR. please take a look

Copy link
Collaborator

@20001LastOrder 20001LastOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@20001LastOrder 20001LastOrder merged commit ffa7286 into main Jun 28, 2024
4 checks passed
@20001LastOrder 20001LastOrder deleted the pdf_qa_demo branch June 28, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants