Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] replace question answering demo with the new PDF reader tutorial demo #395

Closed
amirfz opened this issue Jun 25, 2024 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@amirfz
Copy link
Contributor

amirfz commented Jun 25, 2024

Describe the bug
currently there's a "question answering" demo that references slack app util and other things that no longer exist.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/Aggregate-Intellect/sherpa/tree/main/demo/question_answering
  2. Try to run this locally (I assumed this is the PDF reader tutorial)
  3. I got a slackapp util error and was confused for a while before I realized that this is not the PDF qa tutorial

Expected behavior
This is no longer a good demo since the library has changed and now our primary tutorial is the PDF qa one. However, the PDF tutorial only exists in the docs and not as a runnable demo. We should delete this demo and create a new one based on the PDF reader.

Screenshots
image

Environment
n/a

Additional context
n/a

@amirfz amirfz added the bug Something isn't working label Jun 25, 2024
amirfz added a commit that referenced this issue Jun 25, 2024
@amirfz amirfz mentioned this issue Jun 25, 2024
16 tasks
@linear linear bot closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant