Removed /sessions related code from the cartridge #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zenit2001
requested review from
maassenbas,
amihajlovski and
shanikantsingh
as code owners
shanikantsingh
approved these changes
Feb 21, 2024
amihajlovski
approved these changes
Feb 22, 2024
zenit2001
merged commit fd7938b
into
improvement/sfi-549-remove-sessions
15 checks passed
zenit2001
added a commit
that referenced
this pull request
Feb 27, 2024
* Get checkout payment methods adjustment (#1046) * Replaced /sessions with /paymentMethods for apple pay express (#1047) * Replaced /sessions with /paymentMethods from end of checkout (#1049) * Remove sessions call from My Account (#1050) * chore: removed /sessions related code from the cartridge (#1051) * chore: removed services for sessions (#1053)
shanikantsingh
added a commit
that referenced
this pull request
Mar 12, 2024
* Get checkout payment methods adjustment (#1046) * Replaced /sessions with /paymentMethods for apple pay express (#1047) * Replaced /sessions with /paymentMethods from end of checkout (#1049) * Remove sessions call from My Account (#1050) * chore: removed /sessions related code from the cartridge (#1051) * chore: removed services for sessions (#1053) * chore: disabled linter temporarily * chore: updated eslint ignore * chore: move frontend code to app_adyen_SFRA * chore: fix eslint issues --------- Co-authored-by: Zenit Shkreli <[email protected]>
zenit2001
added a commit
that referenced
this pull request
Apr 23, 2024
* Move BE code to int_adyen_SFRA (#1056) * move frontend code to app_adyen_SFRA (#1057) * Get checkout payment methods adjustment (#1046) * Replaced /sessions with /paymentMethods for apple pay express (#1047) * Replaced /sessions with /paymentMethods from end of checkout (#1049) * Remove sessions call from My Account (#1050) * chore: removed /sessions related code from the cartridge (#1051) * chore: removed services for sessions (#1053) * chore: disabled linter temporarily * chore: updated eslint ignore * chore: move frontend code to app_adyen_SFRA * chore: fix eslint issues --------- Co-authored-by: Zenit Shkreli <[email protected]> * Restructure folders for logging and webhooks (#1059) * chore: added lint to some files in int_adyen_SFRA (#1060) * Moved all adyen util files to the same folder (#1061) * Passing amount to giftcard component on creation (#1066) * Moved adyen scripts under the same directory and groupped them based on functionality (#1064) * GitHub pipeline adjustement (#1065) * Merging changes of develop into SFI-544 (#1068) * chore: added paypal line items feature * chore: added tests for paypal line items --------- Co-authored-by: Shani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe the changes proposed in this pull request:
Removing /sessions from the cartridge
Removing unused /sessions related code from the cartridge, as all the parts are using /paymentMethods.
Tested scenarios
Description of tested scenarios:
Fixed issue: SFI-561