Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed services for sessions #1053

Conversation

zenit2001
Copy link
Contributor

Summary

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    Removing sessions from the cartridge.
  • What existing problem does this pull request solve?
    It removes the /sessions endpoints, since they are not being used anymore in the cartridge.

Tested scenarios

Description of tested scenarios:

@zenit2001 zenit2001 changed the title chore: removed services for sessions Removed services for sessions Feb 22, 2024
@zenit2001 zenit2001 added the refactor Refactors existing code label Feb 22, 2024
@zenit2001 zenit2001 marked this pull request as ready for review February 22, 2024 13:41
@zenit2001 zenit2001 merged commit 71bdca7 into improvement/sfi-549-remove-sessions Feb 26, 2024
14 checks passed
@zenit2001 zenit2001 deleted the improvement/remove-sessions-services branch February 26, 2024 09:29
zenit2001 added a commit that referenced this pull request Feb 27, 2024
* Get checkout payment methods adjustment (#1046)

* Replaced /sessions with /paymentMethods for apple pay express (#1047)

* Replaced /sessions with /paymentMethods from end of checkout (#1049)

* Remove sessions call from My Account (#1050)

* chore: removed /sessions related code from the cartridge (#1051)

* chore: removed services for sessions (#1053)
shanikantsingh added a commit that referenced this pull request Mar 12, 2024
* Get checkout payment methods adjustment (#1046)

* Replaced /sessions with /paymentMethods for apple pay express (#1047)

* Replaced /sessions with /paymentMethods from end of checkout (#1049)

* Remove sessions call from My Account (#1050)

* chore: removed /sessions related code from the cartridge (#1051)

* chore: removed services for sessions (#1053)

* chore: disabled linter temporarily

* chore: updated eslint ignore

* chore: move frontend code to app_adyen_SFRA

* chore: fix eslint issues

---------

Co-authored-by: Zenit Shkreli <[email protected]>
zenit2001 added a commit that referenced this pull request Apr 23, 2024
* Move BE code to int_adyen_SFRA (#1056)

* move frontend code to app_adyen_SFRA (#1057)

* Get checkout payment methods adjustment (#1046)

* Replaced /sessions with /paymentMethods for apple pay express (#1047)

* Replaced /sessions with /paymentMethods from end of checkout (#1049)

* Remove sessions call from My Account (#1050)

* chore: removed /sessions related code from the cartridge (#1051)

* chore: removed services for sessions (#1053)

* chore: disabled linter temporarily

* chore: updated eslint ignore

* chore: move frontend code to app_adyen_SFRA

* chore: fix eslint issues

---------

Co-authored-by: Zenit Shkreli <[email protected]>

* Restructure folders for logging and webhooks (#1059)

* chore: added lint to some files in int_adyen_SFRA (#1060)

* Moved all adyen util files to the same folder (#1061)

* Passing amount to giftcard component on creation (#1066)

* Moved adyen scripts under the same directory and groupped them based on functionality (#1064)

* GitHub pipeline adjustement (#1065)

* Merging changes of develop into SFI-544 (#1068)

* chore: added paypal line items feature

* chore: added tests for paypal line items

---------

Co-authored-by: Shani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactors existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants