-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: bfrosik <[email protected]>
…cohere, removed preprocess script as redundant
…ed auto preprocessing to mp
* Updated multipeak phasing to work with direct phase/strain coupling * A few bugfixes Make sure the results get saved in the right place, etc. * Fixed an oversight that allowed each rotated Bragg peak to have a different voxel size. * Calculates correct voxel size for visualization * Creates a mask which indicates post-interpolation pixels that likely have detectable signal in reciprocal space, but were beyond the scan range in one or more dimensions. * Removed .idea directory from version control. * Fixed broken path name (trying to load wrong config file) * Refactored to record the B_recip matrix rather than applying the actual transform * Add some additional useful information to the saved geometry: lattice size, rs and ds voxel size. * Add some additional useful information to the saved geometry: final_size * fixed crop issue * Compatibility updates * Fixed compatibility with Cohere's Dev branch * Fixed bug that caused multipeak visualization to save in the wrong directory. It was trying to save to exp_dir/results_phasing/results_viz, when it should have been saving to exp_dir/results_viz --------- Co-authored-by: bfrosik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding development branch for new release.