Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mv3 info in kb #533

Merged
merged 36 commits into from
Sep 13, 2024
Merged

add mv3 info in kb #533

merged 36 commits into from
Sep 13, 2024

Conversation

SeverAnna
Copy link
Contributor

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a checklist for all changes required in the knowledge base?

This article alone is far from enough so please share the full checklist in private.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a task to create an article about mv3, which should include:

  • main changes in functionality/interface
  • technical information about modifiers
  • an additional article about unpacking mechanics and how to modify static filters, which was mentioned above.
    Also duplicate the link to the task personally

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@105th do we?

the task was to add info from Notion
https://www.notion.so/adguard/MV3-2df12c0c086541818013bca0aad627ac
and from the blog

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a separate column should be added to the compatibility tables as well, isn't it?
https://uploads.adguard.org/slm4F8W0AcDyhUy3X9.png

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SeverAnna this question should be addressed to our PM's.

as i see, we should add at least:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlinaNaletova @vozersky need your answer here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@el-termikael we already talked about it but i will state it here once again:

That's what we need to finish:

Copy link
Contributor

@el-termikael el-termikael Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vozersky it would be great if you crate a Jira task for that or update the existing one (AGM-2120)

docs/adguard-browser-extension/mv3-version.md Outdated Show resolved Hide resolved
docs/adguard-browser-extension/mv3-version.md Outdated Show resolved Hide resolved
docs/adguard-browser-extension/mv3-version.md Outdated Show resolved Hide resolved
docs/adguard-browser-extension/mv3-version.md Outdated Show resolved Hide resolved
@vbagirov vbagirov requested a review from ameshkov July 26, 2024 15:58
Copy link
Member

@ameshkov ameshkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are not addressed

added more info and fixed mistakes
@SeverAnna SeverAnna requested a review from 105th July 30, 2024 07:50
@SeverAnna SeverAnna requested a review from ameshkov July 31, 2024 12:39
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone?

as per requested changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SeverAnna this question should be addressed to our PM's.

as i see, we should add at least:

docs/adguard-browser-extension/mv3-version.md Outdated Show resolved Hide resolved
docs/adguard-browser-extension/mv3-version.md Outdated Show resolved Hide resolved
docs/adguard-browser-extension/mv3-version.md Outdated Show resolved Hide resolved
docs/adguard-browser-extension/mv3-version.md Outdated Show resolved Hide resolved
docs/adguard-browser-extension/mv3-version.md Outdated Show resolved Hide resolved
docs/adguard-browser-extension/mv3-version.md Outdated Show resolved Hide resolved
@SeverAnna SeverAnna changed the title add mv3 article add mv3 info in kb Aug 7, 2024
added info in "how to create filters", grouped modifiers in a table in "MV3", cosmetic improvements
@SeverAnna SeverAnna requested a review from vozersky August 8, 2024 05:05
@@ -316,6 +316,7 @@ If you want the rule not to be applied to certain apps, start the app name with

Apps in the modifier value cannot have a wildcard, e.g. `$app=com.*.music`.
Rules with such modifier are considered invalid.
In AdGuard Browser Extension MV3, regexps and any tld domains are not supported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"AdGuard Browser Extension MV3" or "AdGuard for Chrome MV3"?

What will we do when it's released (in a couple of weeks) and the main extension will become MV3?

Copy link
Contributor

@el-termikael el-termikael Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vozersky @AlinaNaletova any thoughts on the naming? (this is also mentioned in Andrey's comment below)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say "AdGuard AdBlocker (MV3)" or even "AdGuard AdBlocker" will be fine for Chrome store

docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
Copy link

@AlinaNaletova AlinaNaletova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need to take into account the technical details proposed by the developers.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a task to create an article about mv3, which should include:

  • main changes in functionality/interface
  • technical information about modifiers
  • an additional article about unpacking mechanics and how to modify static filters, which was mentioned above.
    Also duplicate the link to the task personally

docs/adguard-browser-extension/mv3-version.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
Copy link
Contributor

@slavaleleka slavaleleka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts should be resolved


:::

:::info Compatibility

Such rules with `$domain` modifier are supported by AdGuard for Windows, AdGuard for Mac, AdGuard for Android,
and AdGuard Browser Extension for Chrome, Firefox, Edge.
AdGuard Browser Extension for Chrome, Firefox, Edge,
and AdGuard Chrome for MV3.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AdGuard Chrome for MV3 is inconsistent with other product names
is it final?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not final, I will change it when the PMs have a decision on a name

docs/general/ad-filtering/create-own-filters.md Outdated Show resolved Hide resolved
Copy link
Contributor

@el-termikael el-termikael Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vozersky it would be great if you crate a Jira task for that or update the existing one (AGM-2120)

Copy link
Member

@105th 105th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vozersky vozersky merged commit bfc5752 into master Sep 13, 2024
4 checks passed
@ameshkov ameshkov deleted the agm-2120-add-mv3-article branch September 19, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants