-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mv3 info in kb #533
add mv3 info in kb #533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a checklist for all changes required in the knowledge base?
This article alone is far from enough so please share the full checklist in private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a task to create an article about mv3, which should include:
- main changes in functionality/interface
- technical information about modifiers
- an additional article about unpacking mechanics and how to modify static filters, which was mentioned above.
Also duplicate the link to the task personally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@105th do we?
the task was to add info from Notion
https://www.notion.so/adguard/MV3-2df12c0c086541818013bca0aad627ac
and from the blog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a separate column should be added to the compatibility tables as well, isn't it?
https://uploads.adguard.org/slm4F8W0AcDyhUy3X9.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SeverAnna this question should be addressed to our PM's.
as i see, we should add at least:
- separate article about MV3
- article about debugging rules in MV3
--- these you already started ---- - add info about supported rules to the table as @slavaleleka mentioned
- for each rule on the https://adguard.com/kb/general/ad-filtering/create-own-filters/ we should add or update disclaimer about restrictions or unsupported statuses (https://uploads.adguard.org/Snimok_ekrana_2024-08-05_v_17.23.47.png)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlinaNaletova @vozersky need your answer here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@el-termikael we already talked about it but i will state it here once again:
That's what we need to finish:
- general article about MV3 with all the info (including the supported modifiers table) to keep everything in one place.
- article about debugging rules in MV3
- update the https://adguard.com/kb/general/ad-filtering/create-own-filters/ article with mv3 restriction disclaimers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vozersky it would be great if you crate a Jira task for that or update the existing one (AGM-2120)
Co-authored-by: Andrey Meshkov <[email protected]>
…Team/KnowledgeBase into agm-2120-add-mv3-article
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments are not addressed
added more info and fixed mistakes
docs/adguard-browser-extension/solving-problems/update-rules.md
Outdated
Show resolved
Hide resolved
docs/adguard-browser-extension/solving-problems/update-rules.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyone?
as per requested changes
docs/adguard-browser-extension/solving-problems/update-rules.md
Outdated
Show resolved
Hide resolved
docs/adguard-browser-extension/solving-problems/update-rules.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SeverAnna this question should be addressed to our PM's.
as i see, we should add at least:
- separate article about MV3
- article about debugging rules in MV3
--- these you already started ---- - add info about supported rules to the table as @slavaleleka mentioned
- for each rule on the https://adguard.com/kb/general/ad-filtering/create-own-filters/ we should add or update disclaimer about restrictions or unsupported statuses (https://uploads.adguard.org/Snimok_ekrana_2024-08-05_v_17.23.47.png)
added info in "how to create filters", grouped modifiers in a table in "MV3", cosmetic improvements
@@ -316,6 +316,7 @@ If you want the rule not to be applied to certain apps, start the app name with | |||
|
|||
Apps in the modifier value cannot have a wildcard, e.g. `$app=com.*.music`. | |||
Rules with such modifier are considered invalid. | |||
In AdGuard Browser Extension MV3, regexps and any tld domains are not supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"AdGuard Browser Extension MV3" or "AdGuard for Chrome MV3"?
What will we do when it's released (in a couple of weeks) and the main extension will become MV3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vozersky @AlinaNaletova any thoughts on the naming? (this is also mentioned in Andrey's comment below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say "AdGuard AdBlocker (MV3)" or even "AdGuard AdBlocker" will be fine for Chrome store
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also need to take into account the technical details proposed by the developers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a task to create an article about mv3, which should include:
- main changes in functionality/interface
- technical information about modifiers
- an additional article about unpacking mechanics and how to modify static filters, which was mentioned above.
Also duplicate the link to the task personally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conflicts should be resolved
|
||
::: | ||
|
||
:::info Compatibility | ||
|
||
Such rules with `$domain` modifier are supported by AdGuard for Windows, AdGuard for Mac, AdGuard for Android, | ||
and AdGuard Browser Extension for Chrome, Firefox, Edge. | ||
AdGuard Browser Extension for Chrome, Firefox, Edge, | ||
and AdGuard Chrome for MV3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AdGuard Chrome for MV3 is inconsistent with other product names
is it final?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not final, I will change it when the PMs have a decision on a name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vozersky it would be great if you crate a Jira task for that or update the existing one (AGM-2120)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.