Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PopSugar.co.uk - Required user action blocked (AdGuard Annoyances filter) #20596

Closed
THEtomaso opened this issue Aug 3, 2018 · 10 comments
Closed

Comments

@THEtomaso
Copy link

THEtomaso commented Aug 3, 2018

Affected site:

https://www.popsugar.co.uk/

Issue:

Required user action (cookie consent) is blocked, preventing access to the site.
(GDPR related)

Problem filter:

AdGuard Annoyances filter

Problem rule:

###_evidon_banner

Possible fix:

popsugar.co.uk#@##_evidon_banner

--

  • OS/version: Windows 8.1 Pro (x64)
  • Browser/version: Pale Moon v27.9.4 (x64)
  • Adblock Extension/version: uBlock Origin v1.16.4.4 (XUL)
Alex-302 added a commit that referenced this issue Aug 3, 2018
@Alex-302
Copy link
Member

Alex-302 commented Aug 3, 2018

Can't reproduce.
Please check(added to the filter):
||c.evidon.com/sitenotice/evidon-barrier.js

@THEtomaso
Copy link
Author

THEtomaso commented Aug 3, 2018

||c.evidon.com/sitenotice/evidon-barrier.js

Not so fast.. that doesn't fix anything, but makes things worse instead!!
For it to work, you HAVE to whitelist the cosmetic rule that I refered to in my first post!
Also, you will now have to remove the new rule that you've added!

Like I pointed out; accepting the cookie consent is a required user action.
If you block it, the site won't load!

The reason why you weren't able to reproduce the issue is probably because you're not accessing the site from within EU, and are therefore being redirected to the .com or .com.au domain.
It's a GDPR problem, and only the .co.uk domain seems to be affected.
So, the fix shuld be like this:
popsugar.co.uk#@##_evidon_banner

@THEtomaso
Copy link
Author

THEtomaso commented Aug 4, 2018

Indeed, there seems to be some location- or browser dependent differences at work when trying to access the site, even from within the EU.
From my end, this is a essential script:
https://c.evidon.com/sitenotice/evidon-banner.js
..but for some other users, the very same script doesn't seem to be required at all, or even attempted to be accessed.
The same thing seems to be true for the cosmetic rule in question..
For some people, it completely blocks the cookie consent, and thereby prevents access to the site, while for other users, it doesn't matter at all!

More info here (with tests):
ryanbr/fanboy-adblock#512

@THEtomaso
Copy link
Author

I just gave it a try, using SRWare Iron, which is a Chromium-based browser..
The results were exactly the same as they were with Pale Moon and SeaMonkey, which are the other two browsers that I've tested this with.
So, I guess this rules out UA sniffing (and any other forms of browser discrimination) on the server-side.
The differences that we're experiencing must therefore be location-dependent!
I'm connecting from Norway, so if anyone is interested in trying to reproduce this iussue, I guess you should try connecting from a Scandinavian proxy.

@krystian3w
Copy link
Contributor

193.234.157.214:8080 and Bokmål / Nynorsk prefer language:

image
image

@THEtomaso
Copy link
Author

THEtomaso commented Aug 4, 2018

Very strange.
You're still getting a completely different cookie consent warning than I am.
Here's the one that I'm getting (in English language):

filterissue-popsugar3

I see that you were using a Swedish proxy though.
Do you have the option of using a Norwegian one by any chance?
..or perhaps you could just still use the Swedish one, and change your prefered language to English?

@krystian3w
Copy link
Contributor

Do you have the option of using a Norwegian one by any chance?

Nope, few free when I tested did not allow connection.


..or perhaps you could just still use the Swedish one, and change your prefered language to English?

Then I keep the same that in English.

@THEtomaso
Copy link
Author

THEtomaso commented Aug 4, 2018

The issue have been confirmed now, and it seems to be limited to non-EU European countries.
Read from this post and down (From "OFF TOPIC" to "BACK ON TOPIC"):
DandelionSprout/adfilt#7 (comment)

Perhaps now, Alex-302, you'll reconsider to submit the necessary exception to AdGuard's Annoyances filter?

--

EDIT:

A detailed explanation of what's actually happening:
DandelionSprout/adfilt#7 (comment)

Basically, the script https://c.evidon.com/sitenotice/4134/popsugar/settings.js contains a bunch of different country codes (the numbers at the end of each line) which determines which scripts the users will be redirected to next.
It doesn't only serve one script for European countries, and another script for non-European countries, but it also differentiates between various European countries.
This of course makes the whole issue extremely difficult for filter authors to reproduce.

So, in this case, the exception popsugar.co.uk#@##_evidon_banner IS needed for AdGuard's Annoyances filter (although it depends on your location)!
And this new rule probably needs to be deleted too (which I'm unable to confirm from my location):
#20596 (comment)

@krystian3w
Copy link
Contributor

Brexit...

@THEtomaso THEtomaso changed the title PopSugar.* - Required user action blocked (AdGuard Annoyances filter) PopSugar.co.uk - Required user action blocked (AdGuard Annoyances filter) Aug 5, 2018
Alex-302 added a commit that referenced this issue Aug 6, 2018
@Alex-302
Copy link
Member

Alex-302 commented Aug 6, 2018

ok, added exclusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants