Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert sandboxing #3005

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Revert sandboxing #3005

merged 4 commits into from
Jan 9, 2024

Conversation

MDrakos
Copy link
Member

@MDrakos MDrakos commented Jan 9, 2024 •
edited by github-actions bot
Loading

TaskDX-2442 Consider rolling back CI integration test sandbox changes and into a new, comprehensive PR

MDrakos added 4 commits January 9, 2024 13:55
@MDrakos
Revert "Merge pull request #2993 from ActiveState/DX-2432"
c485f4d 
This reverts commit 2daddca, reversing
changes made to a8acdaf.
@MDrakos
Revert "Merge pull request #2991 from ActiveState/mitchell/dx-2426"
e684730 
This reverts commit a8acdaf, reversing
changes made to c4b2ad0.
@MDrakos
Revert "Merge pull request #2989 from ActiveState/mitchell/dx-2427"
8d0c9e7 
This reverts commit c4b2ad0, reversing
changes made to d6c5306.
@MDrakos
Revert "Merge pull request #2941 from ActiveState/DX-2285"
2994d0c 
This reverts commit 91f0fd8, reversing
changes made to 372e2a8.
@MDrakos MDrakos requested a review from mitchell-as January 9, 2024 22:16
@MDrakos
Copy link
Member Author

MDrakos commented Jan 9, 2024

It looks like there are some legitimate test failures. I don't see how they could be caused by this PR but I'm open to fixing them here or getting this in and fixing them through our normal process.

mitchell-as
mitchell-as approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@mitchell-as mitchell-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in, and then you can unabandon any new nightly failures that are occurring here and investigate.

@MDrakos MDrakos merged commit 4c8e6b3 into version/0-44-0-RC1 Jan 9, 2024
6 of 13 checks passed
@MDrakos MDrakos deleted the DX-2442 branch January 9, 2024 23:12
as-builds added a commit that referenced this pull request Jan 9, 2024
@as-builds
Merge branch version/0-44-0-RC1 to adopt changes from PR #3005
bb9a265
MDrakos added a commit that referenced this pull request Jan 9, 2024
@MDrakos
Revert "Merge pull request #3005 from ActiveState/DX-2442"
f1d6d81 
This reverts commit 4c8e6b3, reversing
changes made to eb39e1a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchell-as mitchell-as mitchell-as approved these changes

Assignees
No one assigned
Labels
Test: all
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MDrakos @mitchell-as