Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The CI environment sandbox needs to pass through ACTIVESTATE_CI. #2991

Merged
merged 1 commit into from
Jan 5, 2024
Merged

The CI environment sandbox needs to pass through ACTIVESTATE_CI. #2991

merged 1 commit into from
Jan 5, 2024

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Jan 5, 2024 •
edited by github-actions bot
Loading

BugDX-2426 Nightly failure: TestAnalyticsIntegrationTestSuite/TestCIAndInteractiveDimensions

Otherwise analytics will be skewed.

@mitchell-as mitchell-as changed the base branch from master to version/0-44-0-RC1 January 5, 2024 16:30
@mitchell-as mitchell-as requested a review from MDrakos January 5, 2024 16:33
@mitchell-as mitchell-as marked this pull request as ready for review January 5, 2024 16:33
@mitchell-as
Copy link
Contributor Author

We cannot set it in e2e/env.go's sandboxedTestEnvironment() due to this:

cli/test/integration/analytics_int_test.go

Lines 681 to 682 in 4f98e76

suite.Equal(condition.OnCI(), // not InActiveStateCI() because if it's false, we forgot to set ACTIVESTATE_CI env var in GitHub Actions scripts
*e.Dimensions.ActiveStateCI, "analytics did not report being in ActiveState CI")

@mitchell-as mitchell-as merged commit a8acdaf into version/0-44-0-RC1 Jan 5, 2024
11 of 16 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-2426 branch January 5, 2024 17:22
as-builds added a commit that referenced this pull request Jan 5, 2024
@as-builds
Merge branch version/0-44-0-RC1 to adopt changes from PR #2991
d32c0c0
MDrakos added a commit that referenced this pull request Jan 9, 2024
@MDrakos
Revert "Merge pull request #2991 from ActiveState/mitchell/dx-2426"
e684730 
This reverts commit a8acdaf, reversing
changes made to c4b2ad0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDrakos MDrakos MDrakos approved these changes

Assignees
No one assigned
Labels
Test: analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @MDrakos