Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert: Build scripts should use buildexpression types. #2788

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Revert: Build scripts should use buildexpression types. #2788

merged 1 commit into from
Oct 3, 2023

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Oct 3, 2023 •
edited by github-actions bot
Loading

StoryDX-1961 Unify BuildPlanner and Local Order Build Expression types

A few tests that rely on build script/build expression equality break because incoming build expressions are not ordered.

@mitchell-as
Revert "Merge pull request #2774 from ActiveState/mitchell/dx-1961"
e5cb1e0 
This reverts commit 7b0308d, reversing
changes made to 30a336c.
@mitchell-as mitchell-as requested a review from MDrakos October 3, 2023 20:45
@mitchell-as mitchell-as marked this pull request as ready for review October 3, 2023 20:45
@mitchell-as mitchell-as mentioned this pull request Oct 3, 2023
Closed
@mitchell-as mitchell-as merged commit 3b53897 into version/0-42-0-RC1 Oct 3, 2023
8 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-1961-2 branch October 3, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDrakos MDrakos MDrakos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @MDrakos