Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert: Update shell rcfiles to indicate the user is already in an activated state (v42). #2786

Closed
wants to merge 2 commits into from

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Oct 3, 2023

StoryDX-2239 Remove virtual environment indication

It's broken :(

@github-actions github-actions bot changed the base branch from version/0-42-0-RC1 to version/0-41-0-RC2 October 3, 2023 20:01
@mitchell-as mitchell-as closed this Oct 3, 2023
@mitchell-as mitchell-as deleted the mitchell/dx-2239 branch October 3, 2023 20:02
@mitchell-as mitchell-as restored the mitchell/dx-2239 branch October 3, 2023 20:09
@mitchell-as mitchell-as reopened this Oct 3, 2023
@mitchell-as mitchell-as changed the base branch from version/0-41-0-RC2 to version/0-42-0-RC1 October 3, 2023 20:09
@mitchell-as mitchell-as closed this Oct 3, 2023
@mitchell-as mitchell-as reopened this Oct 3, 2023
This reverts commit 03d08e6, reversing
changes made to 796ddea.
@mitchell-as mitchell-as changed the title Revert: Update shell rcfiles to indicate the user is already in an activated state. Revert: Update shell rcfiles to indicate the user is already in an activated state (v42). Oct 3, 2023
@github-actions github-actions bot changed the base branch from version/0-42-0-RC1 to version/0-41-0-RC2 October 3, 2023 20:22
@mitchell-as mitchell-as changed the base branch from version/0-41-0-RC2 to version/0-42-0-RC1 October 3, 2023 20:22
@mitchell-as
Copy link
Contributor Author

mitchell-as commented Oct 3, 2023

#2787 will fail to propagate to v42 due to a conflict in shell_int_test.go. The resolution is to remove the TestNestedShellNotification() function, but leave the existing TestRuby() function.

@mitchell-as
Copy link
Contributor Author

Test failures are due to #2788, which is not related to this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant