Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed the NFT trait to InspectExtended #1841

Closed
wants to merge 4 commits into from
Closed

Conversation

syan095
Copy link
Contributor

@syan095 syan095 commented Feb 3, 2022

No description provided.

@syan095 syan095 requested review from xlc and shaunxw February 3, 2022 02:01
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #1841 (315e66e) into master (48ca09e) will increase coverage by 0.26%.
The diff coverage is 60.00%.

❗ Current head 315e66e differs from pull request most recent head a29ea50. Consider uploading reports for the commit a29ea50 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1841      +/-   ##
==========================================
+ Coverage   85.45%   85.71%   +0.26%     
==========================================
  Files          77       76       -1     
  Lines       16623    16495     -128     
==========================================
- Hits        14205    14139      -66     
+ Misses       2418     2356      -62     
Impacted Files Coverage Δ
modules/homa-lite/src/mock_no_fees.rs 67.92% <ø> (ø)
modules/homa-lite/src/tests.rs 99.79% <ø> (ø)
modules/nft/src/benchmarking.rs 0.00% <ø> (ø)
modules/relaychain/src/lib.rs 76.66% <ø> (ø)
modules/xcm-interface/src/lib.rs 0.00% <0.00%> (ø)
primitives/src/lib.rs 88.57% <ø> (ø)
primitives/src/nft.rs 54.54% <54.54%> (ø)
modules/homa/src/lib.rs 85.04% <85.71%> (-0.18%) ⬇️
modules/homa-lite/src/lib.rs 89.73% <100.00%> (ø)
modules/evm/src/lib.rs 63.52% <0.00%> (-0.15%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf97a0...a29ea50. Read the comment docs.

@xlc
Copy link
Member

xlc commented Feb 3, 2022

need to update orml again

@syan095
Copy link
Contributor Author

syan095 commented Feb 3, 2022

orml Master is currently un-compatible with curernt acala master. I think i will need to wait for :
#1765
to merge

zqhxuyuan added a commit that referenced this pull request Feb 4, 2022
@zqhxuyuan
Copy link
Contributor

closed in #1765

@zqhxuyuan zqhxuyuan closed this Feb 8, 2022
@syan095 syan095 deleted the refactor/nft-trait branch March 16, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants