Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to v0.9.16 #1765

Merged
merged 54 commits into from
Feb 7, 2022
Merged

upgrade to v0.9.16 #1765

merged 54 commits into from
Feb 7, 2022

Conversation

zqhxuyuan
Copy link
Contributor

@zqhxuyuan zqhxuyuan commented Jan 10, 2022

xcm related:

removal Default:

client:

  • cumulus consensus refactor

runtime new pallet:

tests:

  • kusama native asset: karura native asset test #1768
    • current karura and sibling both use same runtime, so their native asset both is KAR, need integration-tests to manual adapt/fixed the para_id to 2000
  • test-service(version <= 0.9.15 has compile error of client type, so moved here)

upgrade guide:

  • canonical reanchored location: before we upgrade, make sure bifrost already compatible. and current it's already done in bifrost side.
  • statemine asset prefix location we don't need compatible because we use foreign_asset_id internal, but after statemine upgrade, we must change RMRK location on asset-registry from (1, X2(1000, GenealIndex(8))) to (1, X3(1000, PalletInstance(50), GeneralIndex(8)))

@zqhxuyuan zqhxuyuan changed the title v0.9.15 dependen on master Jan 14, 2022
@zqhxuyuan zqhxuyuan changed the title dependen on master dependent on master Jan 14, 2022
@sander2
Copy link
Contributor

sander2 commented Jan 31, 2022

Sorry to intrude on your PR, but I have a question. Do you know if the following change is required as well? I suspect that maybe polkadot/substrate will automatically canonicalize it, in which case it doesn't matter, but tbh I am not completely sure where the new simplify function gets called. I'm asking because we use some very similar runtime code.

fn native_currency_location(id: CurrencyId) -> MultiLocation {
-    MultiLocation::new(1, X2(Parachain(ParachainInfo::get().into()), GeneralKey(id.encode())))
+    MultiLocation::new(0, X1(GeneralKey(id.encode())))
}

@zqhxuyuan
Copy link
Contributor Author

don't need change native_currency_location(). as the new canonical reanchored only change the meaning of to-reserve/non-reserve case. i.e ParaB transfer token A to ParaA, from the point view of ParaA, the location is changed. But for the case of ParaA transfer token A to ParaB. we do not need to change native_currency_location() as xtokens will invoke reanchor, the for the point view of ParaB, the location not change, still got (1, 2000, A).

modules/collator-selection/src/tests.rs Outdated Show resolved Hide resolved
modules/evm/src/lib.rs Show resolved Hide resolved
modules/homa-lite/src/mock.rs Outdated Show resolved Hide resolved
modules/homa-lite/src/mock_no_fees.rs Outdated Show resolved Hide resolved
primitives/src/signature.rs Outdated Show resolved Hide resolved
primitives/src/signature.rs Outdated Show resolved Hide resolved
runtime/acala/src/lib.rs Outdated Show resolved Hide resolved
runtime/acala/src/lib.rs Show resolved Hide resolved
runtime/karura/src/lib.rs Outdated Show resolved Hide resolved
runtime/karura/src/lib.rs Outdated Show resolved Hide resolved
runtime/karura/src/lib.rs Outdated Show resolved Hide resolved
@sander2
Copy link
Contributor

sander2 commented Feb 4, 2022

Another headsup: I found in kintsugi testing on rococo-local that we needed to canonicalize the chain-local assetids in the PerSecond Trader items

@zqhxuyuan
Copy link
Contributor Author

zqhxuyuan commented Feb 5, 2022

Another headsup: I found in kintsugi testing on rococo-local that we needed to canonicalize the chain-local assetids in the PerSecond Trader items

👍 I'll revisit Trader config, as we're missing transfer native asset test, previous I add some code but delete them as I need to add integration-tests a few place. I think KarPerSecondOfCanonicalLocation should added to production case, not integration-tests case.

@zqhxuyuan zqhxuyuan merged commit 7a29682 into master Feb 7, 2022
@zqhxuyuan zqhxuyuan deleted the new_reanchor branch February 7, 2022 01:53
@ferrell-code ferrell-code mentioned this pull request Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new reanchor compatible change
5 participants