exrcheck: reduceMemory now checks pixel size and scanline compression mode #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Hillman <[email protected]>
Signed-off-by: Peter Hillman <[email protected]>
cary-ilm
pushed a commit
that referenced
this pull request
Mar 28, 2021
… mode (#987) * exrcheck: reduceMemory checks pixel size and scanline compression mode Signed-off-by: Peter Hillman <[email protected]> * exrcheck: increase limit for scanlines in reduceMemory mode Signed-off-by: Peter Hillman <[email protected]>
|
Also addressed https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=31172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32370
Apply same logic as #966 to scanlines: when 'reduceMemory' is passed to Imf::CheckOpenEXRFile, computes the amount of memory to read scanline files. Previously only the scanline width was used. This change also accounts the number of scanlines stored in one chunk, which is compression-scheme dependent, and the number of bytes per pixel.
Signed-off-by: Peter Hillman [email protected]