exrcheck: account for size of pixels when estimating memory #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Hillman <[email protected]>
kdt3rd
approved these changes
Mar 15, 2021
|
Let's hold off on this for 3.0.1. We can merge as soon as we cut the RB-3.0
branch, momentarily.
…On Mon, Mar 15, 2021 at 3:53 AM Kimball Thurston ***@***.***> wrote:
***@***.**** approved this pull request.
Not sure whether we want this in prior to 3.0 or not, but looks good to me
either way
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#966 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFC3DGK2SE672SIGZOSAVQ3TDXRJTANCNFSM4ZF3BZDQ>
.
--
Cary Phillips | R&D Supervisor | ILM | San Francisco
|
|
OK to merge this to master now that RB-3.0 is in place. |
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 20, 2021
…oftwareFoundation#966) Signed-off-by: Peter Hillman <[email protected]>
cary-ilm
pushed a commit
that referenced
this pull request
Mar 28, 2021
Signed-off-by: Peter Hillman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32067
Update Imf::checkOpenEXRFile 'reduceMemory' mode to account for size and number of channels, as well as scanline/tile dimensions, when estimating memory consumption. (Example image claims to have 346 channels so RleCompressor allocated a large amount of memory to decode the file)
Signed-off-by: Peter Hillman [email protected]