OpenEXR/ImfStdIO.[cpp h]: Added StdISStream. #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class was missing; ie the "input" stringstream version of StdOSStream. Based off istringstream. Signed-off-by: Arkell Rasiah <[email protected]>
cary-ilm
added
the
Needs Discussion
cary-ilm
approved these changes
Jan 16, 2020
|
I hate to be a pest, but could you add a test for this? In IlmImfTest/testExistingStreams.cpp? It could sit alongside the existing tests. |
|
np... i will put together something... if i recall right stdostream didnt hv a test of it too... so will roll something that does both.
… On Feb 5, 2020, at 08:30, Cary Phillips ***@***.***> wrote:
I hate to be a pest, but could you add a test for this? In IlmImfTest/testExistingStreams.cpp? It could sit alongside the existing tests.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
cary-ilm
added
Awaiting Feedback
|
Pinging @arkellr again, any chance you can find some time to put a test together for this? |
|
... actually made a ticket for this in my current work sprint... and actually will likely start on it tomorrow...
… On Feb 25, 2020, at 20:44, Cary Phillips ***@***.***> wrote:
Pinging @arkellr again, any chance you can find some time to put a test together for this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
…ream. Note I moved the "header" declaration into the scoped block that handles the writing since thats where its only used. Also cleaned up the compiler warning for "_pos < 0"; since _pos is an unsigned type. Signed-off-by: Arkell Rasiah <[email protected]>
|
Cary test case added for Imf::StdOSStream/StdISStream... let me know if you would like to do a zoom to review the updates to testExistingStreams.cpp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class was missing; ie the "input" stringstream version of StdOSStream.
Based off istringstream.
Signed-off-by: Arkell Rasiah [email protected]