ImfStdIO.[cpp h]: Missing StdISStream class

[arkellr]

Just pasting my commit comment which best describe this issue and fix. Will PR it shortly... but creating "an issue" for it first.

OpenEXR/ImfStdIO.[cpp h]: Added StdISStream.

This class was missing; ie the "input" stringstream version of StdOSStream.
Based off istringstream.

[cary-ilm]

@arkellr, were you going to submit a PR?

[arkellr]

hey. cary... thx for following up. Yeah Ive got my two issues #632 and #633 branches ready to be git pushed. (CLA commit signed) But ran into a snag... my “arkellr” cant git push to the openexr repo. In the middle of wrangling why with the CLA admins. Side note: Im working out of Oz at the moment for the next few weeks so couldnt quite jump on todays TSC call to followup... its like 3am here. 🙄 My guess is “arkellr” needs access perms to push; but im not sure if that is auto handled already thru CLA side or the openexr repo admins also need to add arkellr to a group list that can git push the repo.

…

On Jan 10, 2020, at 05:21, Cary Phillips ***@***.***> wrote:  @arkellr, were you going to submit a PR? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[lgritz]

Don't push to the openexr repo.

Clone the repo into your account. Fix and push to YOUR clone. Submit a PR from your clone to the main repo.

[lgritz]

I meant, of course, "fork the repo into your account."

[arkellr]

Thanks Larry… will try that.

…

On Jan 10, 2020, at 6:42 AM, Larry Gritz ***@***.***> wrote: I meant, of course, "fork the repo into your account." — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#633?email_source=notifications&email_token=AMSZ23U2JJLATAZWYQJQFHDQ46R3RA5CNFSM4J2HHSRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEISBOFA#issuecomment-572790548>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMSZ23XLVO6OAEC5HTWX42DQ46R3RANCNFSM4J2HHSRA>.

[cary-ilm]

https://github.com/AcademySoftwareFoundation/openexr/blob/master/CONTRIBUTING.md#use-the-fork-luke On Thu, Jan 9, 2020 at 3:13 PM Arkell Rasiah <[email protected]> wrote:

…

Thanks Larry… will try that. > On Jan 10, 2020, at 6:42 AM, Larry Gritz ***@***.***> wrote: > > I meant, of course, "fork the repo into your account." > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub < #633?email_source=notifications&email_token=AMSZ23U2JJLATAZWYQJQFHDQ46R3RA5CNFSM4J2HHSRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEISBOFA#issuecomment-572790548>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AMSZ23XLVO6OAEC5HTWX42DQ46R3RANCNFSM4J2HHSRA >. > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#633?email_source=notifications&email_token=AFC3DGPKLHL7PDEMXTJRYITQ46VTBA5CNFSM4J2HHSRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEISDYRY#issuecomment-572800071>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFC3DGLTG73Z3C4U54V4JELQ46VTBANCNFSM4J2HHSRA> .

-- Cary Phillips | R&D Supervisor | ILM | San Francisco

[arkellr]

Hah… thanks Cary… with a section title like that… how could I’d have missed it. Will put that down to a self-induced-jedi-mind-trick. ;) Anyhow… those two PRs are in. I will try to make it to your next TSC zoom call… just to followup… 1pm SF time turns out to be only 5am here in W.Australia; which isn’t as early as one might think…since there is no daylight saving in effect here.

…

-Arkell

On Jan 10, 2020, at 8:06 AM, Cary Phillips ***@***.***> wrote: https://github.com/AcademySoftwareFoundation/openexr/blob/master/CONTRIBUTING.md#use-the-fork-luke On Thu, Jan 9, 2020 at 3:13 PM Arkell Rasiah ***@***.***> wrote: > Thanks Larry… will try that. > > > On Jan 10, 2020, at 6:42 AM, Larry Gritz ***@***.***> > wrote: > > > > I meant, of course, "fork the repo into your account." > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub < > #633?email_source=notifications&email_token=AMSZ23U2JJLATAZWYQJQFHDQ46R3RA5CNFSM4J2HHSRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEISBOFA#issuecomment-572790548>, > or unsubscribe < > https://github.com/notifications/unsubscribe-auth/AMSZ23XLVO6OAEC5HTWX42DQ46R3RANCNFSM4J2HHSRA > >. > > > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#633?email_source=notifications&email_token=AFC3DGPKLHL7PDEMXTJRYITQ46VTBA5CNFSM4J2HHSRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEISDYRY#issuecomment-572800071>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFC3DGLTG73Z3C4U54V4JELQ46VTBANCNFSM4J2HHSRA> > . > -- Cary Phillips | R&D Supervisor | ILM | San Francisco — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#633?email_source=notifications&email_token=AMSZ23TMMVMQ6E2CMVJUI6TQ463XFA5CNFSM4J2HHSRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEISHBVI#issuecomment-572813525>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMSZ23XKB6HEQSADYILPXKLQ463XFANCNFSM4J2HHSRA>.

[cary-ilm]

Closing this issue, since the PR is in, #638.