Support relative and absolute libdir/incluedir in pkg-config generation #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During pkg-config generation, CMake now uses `CMAKE_INSTALL_LIBDIR`/`CMAKE_INSTALL_INCLUDEDIR` instead of the `_FULL_` variables, and does not prepend the prefix if they are absolute paths, which makes it possible to support relative installation paths. See AcademySoftwareFoundation/Imath#281 and AcademySoftwareFoundation/Imath#291 Signed-off-by: Cary Phillips <[email protected]>
meshula
approved these changes
Feb 5, 2023
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 3, 2023
…on (AcademySoftwareFoundation#1330) During pkg-config generation, CMake now uses `CMAKE_INSTALL_LIBDIR`/`CMAKE_INSTALL_INCLUDEDIR` instead of the `_FULL_` variables, and does not prepend the prefix if they are absolute paths, which makes it possible to support relative installation paths. See AcademySoftwareFoundation/Imath#281 and AcademySoftwareFoundation/Imath#291 Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
that referenced
this pull request
Mar 5, 2023
…on (#1330) During pkg-config generation, CMake now uses `CMAKE_INSTALL_LIBDIR`/`CMAKE_INSTALL_INCLUDEDIR` instead of the `_FULL_` variables, and does not prepend the prefix if they are absolute paths, which makes it possible to support relative installation paths. See AcademySoftwareFoundation/Imath#281 and AcademySoftwareFoundation/Imath#291 Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During pkg-config generation, CMake now uses
CMAKE_INSTALL_LIBDIR/CMAKE_INSTALL_INCLUDEDIRinstead of the_FULL_variables, and does not prepend the prefix if they are absolute paths, which makes it possible to support relative installation paths.See AcademySoftwareFoundation/Imath#281 and AcademySoftwareFoundation/Imath#291
Signed-off-by: Cary Phillips [email protected]