-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support relative prefix in pkg-config #291
Support relative prefix in pkg-config #291
Conversation
CMake now exports CMAKE_INSTALL_LIBDIR/CMAKE_INSTALL_INCLUDEDIR instead of the *_FULL_* variables, and Imath.pc.in prepends the prefix explicitly, which makes it possible to support relative installation paths Signed-off-by: Cary Phillips <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for getting to this, but this is not sufficient. It only addresses the relocability when CMAKE_INSTALL_LIBDIR/CMAKE_INSTALL_INCLUDEDIR are indeed relative, but for some platforms like NixOS they are actually absolute so this scheme doesn't work out there. Please see the provided links for a workaround that handles both cases. |
Signed-off-by: Cary Phillips <[email protected]>
OK, I added the IS_ABSOLUTE logic you referenced, and this seems to now handle -DCMAKE_INSTALL_INCLUDEDIR=/path. But let me know if there's something this still doesn't address. |
That should be it, thanks! |
During pkg-config generation, CMake now uses `CMAKE_INSTALL_LIBDIR`/`CMAKE_INSTALL_INCLUDEDIR` instead of the `_FULL_` variables, and does not prepend the prefix if they are absolute paths, which makes it possible to support relative installation paths. See AcademySoftwareFoundation/Imath#281 and AcademySoftwareFoundation/Imath#291 Signed-off-by: Cary Phillips <[email protected]>
…on (#1330) During pkg-config generation, CMake now uses `CMAKE_INSTALL_LIBDIR`/`CMAKE_INSTALL_INCLUDEDIR` instead of the `_FULL_` variables, and does not prepend the prefix if they are absolute paths, which makes it possible to support relative installation paths. See AcademySoftwareFoundation/Imath#281 and AcademySoftwareFoundation/Imath#291 Signed-off-by: Cary Phillips <[email protected]>
* Support relative prefix in pkg-config CMake now exports CMAKE_INSTALL_LIBDIR/CMAKE_INSTALL_INCLUDEDIR instead of the *_FULL_* variables, and Imath.pc.in prepends the prefix explicitly, which makes it possible to support relative installation paths Signed-off-by: Cary Phillips <[email protected]> * Add CMake logic to handle relative vs absolute libdir/includedir Signed-off-by: Cary Phillips <[email protected]> --------- Signed-off-by: Cary Phillips <[email protected]>
* Support relative prefix in pkg-config CMake now exports CMAKE_INSTALL_LIBDIR/CMAKE_INSTALL_INCLUDEDIR instead of the *_FULL_* variables, and Imath.pc.in prepends the prefix explicitly, which makes it possible to support relative installation paths Signed-off-by: Cary Phillips <[email protected]> * Add CMake logic to handle relative vs absolute libdir/includedir Signed-off-by: Cary Phillips <[email protected]> --------- Signed-off-by: Cary Phillips <[email protected]>
…on (AcademySoftwareFoundation#1330) During pkg-config generation, CMake now uses `CMAKE_INSTALL_LIBDIR`/`CMAKE_INSTALL_INCLUDEDIR` instead of the `_FULL_` variables, and does not prepend the prefix if they are absolute paths, which makes it possible to support relative installation paths. See AcademySoftwareFoundation/Imath#281 and AcademySoftwareFoundation/Imath#291 Signed-off-by: Cary Phillips <[email protected]>
…on (#1330) During pkg-config generation, CMake now uses `CMAKE_INSTALL_LIBDIR`/`CMAKE_INSTALL_INCLUDEDIR` instead of the `_FULL_` variables, and does not prepend the prefix if they are absolute paths, which makes it possible to support relative installation paths. See AcademySoftwareFoundation/Imath#281 and AcademySoftwareFoundation/Imath#291 Signed-off-by: Cary Phillips <[email protected]>
CMake now exports CMAKE_INSTALL_LIBDIR/CMAKE_INSTALL_INCLUDEDIR instead of the FULL variables, and Imath.pc.in prepends the prefix explicitly, which makes it possible to support relative installation paths
Signed-off-by: Cary Phillips [email protected]