Check for null pointer passed to memcpy #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only happens when the size parameter is 0, in which memcpy will not fail, but SonarCloud flags this as a problem: https://sonarcloud.io/project/issues?resolved=false&sinceLeakPeriod=true&types=BUG&id=AcademySoftwareFoundation_openexr&open=AYPeU0_LmU8C9mUeoOgr Signed-off-by: Cary Phillips <[email protected]>
lgritz
approved these changes
Nov 5, 2022
meshula
approved these changes
Nov 6, 2022
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 3, 2023
This only happens when the size parameter is 0, in which memcpy will not fail, but SonarCloud flags this as a problem: https://sonarcloud.io/project/issues?resolved=false&sinceLeakPeriod=true&types=BUG&id=AcademySoftwareFoundation_openexr&open=AYPeU0_LmU8C9mUeoOgr Signed-off-by: Cary Phillips <[email protected]> Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
that referenced
this pull request
Mar 5, 2023
This only happens when the size parameter is 0, in which memcpy will not fail, but SonarCloud flags this as a problem: https://sonarcloud.io/project/issues?resolved=false&sinceLeakPeriod=true&types=BUG&id=AcademySoftwareFoundation_openexr&open=AYPeU0_LmU8C9mUeoOgr Signed-off-by: Cary Phillips <[email protected]> Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only happens when the size parameter is 0, in which memcpy will not fail, but SonarCloud flags this as a problem:
https://sonarcloud.io/project/issues?resolved=false&sinceLeakPeriod=true&types=BUG&id=AcademySoftwareFoundation_openexr&open=AYPeU0_LmU8C9mUeoOgr
Signed-off-by: Cary Phillips [email protected]