Check for null pointer passed to memcpy (#1296)

This only happens when the size parameter is 0, in which memcpy will not fail, but SonarCloud flags this as a problem: https://sonarcloud.io/project/issues?resolved=false&sinceLeakPeriod=true&types=BUG&id=AcademySoftwareFoundation_openexr&open=AYPeU0_LmU8C9mUeoOgr Signed-off-by: Cary Phillips <[email protected]> Signed-off-by: Cary Phillips <[email protected]>
AcademySoftwareFoundation · Mar 5, 2023 · 7650bbb · 7650bbb
1 parent 16789e4
commit 7650bbb
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/lib/OpenEXRCore/opaque.c b/src/lib/OpenEXRCore/opaque.c
@@ -56,7 +56,7 @@ exr_attr_opaquedata_create (
     exr_result_t rv = exr_attr_opaquedata_init (ctxt, u, b);
     if (rv == EXR_ERR_SUCCESS)
     {
-        if (d) memcpy ((void*) u->packed_data, d, b);
+        if (d && u->packed_data) memcpy ((void*) u->packed_data, d, b);
     }
 
     return rv;