Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes commented out OCIO_BUILD_PYTHON #1055

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Removes commented out OCIO_BUILD_PYTHON #1055

merged 2 commits into from
Jul 9, 2020

Conversation

sobotka
Copy link
Contributor

@sobotka sobotka commented Jul 7, 2020

Fixes #1050.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 7, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

hodoulp
hodoulp approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@hodoulp hodoulp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sobotka & @LazyDodo

Done by @sobotka following a suggestion from @LazyDodo

@hodoulp
Copy link
Member

hodoulp commented Jul 7, 2020

Hi @sobotka
You forgot to sign the commit i.e. git commit -sam "blabla". The DCO details explain how to proceed.

@sobotka
Copy link
Contributor Author

sobotka commented Jul 8, 2020

Ok, I think I have jumped through all successful hoops to have the single character patch accepted. Fingers crossed.

Let me know.

@hodoulp
Copy link
Member

hodoulp commented Jul 8, 2020

@sobotka no success because of the missing sign-off, perhaps @jmertic or @michdolan could help.

@jmertic
Copy link
Collaborator

jmertic commented Jul 8, 2020

Details on the DCO at https://github.com/AcademySoftwareFoundation/tac/blob/master/process/contributing.md#contribution-sign-off.

Looks like you can fix this locally by...

git commit --amend --signoff
git push --force-with-lease origin patch-3

@sobotka
Copy link
Contributor Author

sobotka commented Jul 8, 2020

Sorry, I mistook the "sign" to mean GPG signed.

@hodoulp hodoulp merged commit b843e98 into AcademySoftwareFoundation:master Jul 9, 2020
michdolan pushed a commit to michdolan/OpenColorIO that referenced this pull request Jul 13, 2020
@sobotka @hodoulp @michdolan
Removes commented out OCIO_BUILD_PYTHON (AcademySoftwareFoundation#1055)
54ed8bb 
Fixes AcademySoftwareFoundation#1050. Authored by @LazyDodo.

Signed-off-by: Troy James Sobotka <[email protected]>

Co-authored-by: Patrick Hodoul <[email protected]>
@sobotka sobotka deleted the patch-3 branch July 16, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doug-walker doug-walker doug-walker approved these changes

@hodoulp hodoulp hodoulp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python tests always build even if OCIO_BUILD_PYTHON is off
4 participants
@sobotka @hodoulp @jmertic @doug-walker