Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python tests always build even if OCIO_BUILD_PYTHON is off #1050

Closed
LazyDodo opened this issue Jun 30, 2020 · 7 comments · Fixed by #1055
Closed

Python tests always build even if OCIO_BUILD_PYTHON is off #1050

LazyDodo opened this issue Jun 30, 2020 · 7 comments · Fixed by #1055

Comments

@LazyDodo
Copy link

#1025 updated the python tests, but forgot to un-comment the OCIO_BUILD_PYTHON test in cmake that protected it, meaning they are always on now and you can't build OCIO without python.
@hodoulp
Copy link
Member

hodoulp commented Jul 7, 2020

Good catch @LazyDodo

Would you mind doing the pull request?

@LazyDodo
Copy link
Author

LazyDodo commented Jul 7, 2020

Sorry, the CLA in place for this project prevents me from doing so.

@hodoulp
Copy link
Member

hodoulp commented Jul 7, 2020

You only need to register as an individual contributor or as a corporate contributor (with your legals approval first).

@LazyDodo
Copy link
Author

LazyDodo commented Jul 7, 2020

That will only happen if there is a sizable/worthwhile contribution, the removal of 2 mistakenly placed #'s in a build script is quite some ways away from reaching that bar.

sobotka added a commit to sobotka/OpenColorIO that referenced this issue Jul 7, 2020
@sobotka
Removes commented out OCIO_BUILD_PYTHON
567a2e6 
Fixes AcademySoftwareFoundation#1050.
@sobotka sobotka mentioned this issue Jul 7, 2020
Merged
@LazyDodo
Copy link
Author

LazyDodo commented Jul 7, 2020

Thanks troy!

@sobotka
Copy link
Contributor

sobotka commented Jul 7, 2020

No problem!

I should have put the acknowledgement to @LazyDodo in the commit message. Perhaps @hodoulp can do it on the commit.

@LazyDodo
Copy link
Author

LazyDodo commented Jul 7, 2020 •
edited
Loading

that really doesn't matter, don't worry about it.

sobotka added a commit to sobotka/OpenColorIO that referenced this issue Jul 8, 2020
@sobotka
Removes commented out OCIO_BUILD_PYTHON
dbe6047 
Fixes AcademySoftwareFoundation#1050. Authored by @LazyDodo.
sobotka added a commit to sobotka/OpenColorIO that referenced this issue Jul 8, 2020
@sobotka
Removes commented out OCIO_BUILD_PYTHON
cf7dc15 
Fixes AcademySoftwareFoundation#1050. Authored by @LazyDodo.

Signed-off-by: Troy James Sobotka <[email protected]>
hodoulp added a commit that referenced this issue Jul 9, 2020
@sobotka @hodoulp
Removes commented out OCIO_BUILD_PYTHON (#1055)
b843e98 
Fixes #1050. Authored by @LazyDodo.

Signed-off-by: Troy James Sobotka <[email protected]>

Co-authored-by: Patrick Hodoul <[email protected]>
michdolan pushed a commit to michdolan/OpenColorIO that referenced this issue Jul 13, 2020
@sobotka @hodoulp @michdolan
Removes commented out OCIO_BUILD_PYTHON (AcademySoftwareFoundation#1055)
54ed8bb 
Fixes AcademySoftwareFoundation#1050. Authored by @LazyDodo.

Signed-off-by: Troy James Sobotka <[email protected]>

Co-authored-by: Patrick Hodoul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes commented out OCIO_BUILD_PYTHON sobotka/OpenColorIO
3 participants
@sobotka @LazyDodo @hodoulp