Dev #76
Merged
Dev #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- just keeping the original as reference compared with the second one, if I fix the dithering order then I will remove the original
- and the demo changed completely to a more interesting one
- Regarding the new render pass workgroup parameters
Set worgroups
- bindingIndex has to increase because if not `addBindingTexture` can only add one, so this allows for multiple calls to `addBindingTexture`
- button to download image as png
- If the console is open it detect different dimensions, but if we first assign the fit window method it works - We remember fitWindow value and re assign it after we exit fullscreen
- with better workgroups
- Depending on the data type, not all fields in a struct are 4 bytes, a vec2 has 16 bytes because all vectors occupy 16 no matter what, so because of this, now the user has to be conscious about explicitly say the size of the struct.
- This is static, unless I later decide to make it with a dynamic struct, it must remain the same
- it was never wrong 😄 - the thing is the error is the parameters sent into addStorage, so I have to be careful there
- The code is correct and you can count the basic elements of each struct, meaning f32, i32, u32, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.